Added application/x-font-ttf to the list of allowed media types

[iherman]

These are the possible changes following w3c/epub-specs#667 and w3c/epub-specs#2726.

I followed the advice of @mattgarrish for the files to be changed (w3c/epub-tests#307 (comment) and w3c/epub-tests#307 (comment)). Note, however, that I was not sure what is expected in the two OPF files, mostly what the value of the href attribute should be. I probably got it wrong, it certainly needs a review... But I hope that, nevertheless, this PR helps...

Note that this change is related to EPUB 3.4. I was looking for a label for 3.4, but have not found any (and I did not want to create one, I am just a guest...). I hope I got the other labels right.

[mattgarrish]

Sorry, I forgot to mention that the result file (resource.feature in the parent directory) also needs changing because there's an additional non-preferred media type - it's bumped from 6 to 7 info messages returned because of this addition. I've pushed a fix for that.

The file you reference in the href attribute doesn't matter in a package document-only test. Epubcheck is restricted in this mode to only verifying the package document itself. It doesn't do any further checks on whether there are actual resources associated with the document, etc.

But one oddity of adding this media type is that the test that foreign font types are exempt (you can find it at line 151 of the feature file) now passes because it was using application/x-font-ttf. We need a different media type and I assume not a completely fake one. I'll skim around and see if I can find something else.

(FYI, you can always test if your changes are good by running mvn clean install from the root directory. Epubcheck will build without errors if everything is set to go.)

[iherman]

Sorry, I forgot to mention that the result file (resource.feature in the parent directory) also needs changing because there's an additional non-preferred media type - it's bumped from 6 to 7 info messages returned because of this addition. I've pushed a fix for that.

Thanks

The file you reference in the href attribute doesn't matter in a package document-only test. Epubcheck is restricted in this mode to only verifying the package document itself. It doesn't do any further checks on whether there are actual resources associated with the document, etc.

But one oddity of adding this media type is that the test that foreign font types are exempt (you can find it at line 151 of the feature file) now passes because it was using application/x-font-ttf. We need a different media type and I assume not a completely fake one. I'll skim around and see if I can find something else.

(FYI, you can always test if your changes are good by running mvn clean install from the root directory. Epubcheck will build without errors if everything is set to go.)

Is mvn a java thing? I have no idea what it does... (Last time I did something with Java was, ehem, well, over 25 years ago...)

[mattgarrish]

We need a different media type and I assume not a completely fake one.

The best I can find is to switch it to application/x-font-woff and replace the font file. That seems to have been a valid woff media type at one time.

Is mvn a java thing?

It's the Apache Maven build tool. I don't think it's exclusively for java, but that's how epubcheck is designed to be compiled.

[mattgarrish]

There are some brief instructions on building epubcheck in the repository's readme.

[iherman]

Note: w3c/epub-specs#2726 has been merged, this PR has therefore become relevant...

[rdeltour]

Thanks for the PR @iherman.
Looks all good to me. I added another test and squashed+rebased the commits.