Integrate refactoring and fixes made in the eBraille checker project#1637
Merged
Integrate refactoring and fixes made in the eBraille checker project#1637
Conversation
Previously, EPUBCheck dealt with expanded directories by first zipping them before checking them as a packaged OCF container. This commit implements a new OCF resources provider that walks through a file set without having to archive it first. The testing step is changed to use this facility and no-longer zips the test files before running the tests.
Now allows: - When checking directory '...' - When checking file set '...'
The message PKG-024 is reported when a packaged publication does not have a '.epub' extension, when validating against EPUB 3. It was previously reported as INFO, it is now reported as USAGE.
Using Set(s) caused issues with duplicate metadata, which did not show up in the parsed data structure.
It is still very naive, but is not at least totally wrong
- `q` was not parsed as a length quantity - `ch` was parse an absolute length quantity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.