Adding a slightly darker background to the images in dark mode#25
Merged
Adding a slightly darker background to the images in dark mode#25
Conversation
iherman
changed the title
dlongley
approved these changes
May 7, 2025
Contributor
dlongley
left a comment
dlongley
left a comment
There was a problem hiding this comment.
I cloned the repo and looked at the branch locally and it looked good to me! Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The W3C Dark mode sets the background for each image to white when the document is rendered in dark mode. That means a very large white spot on the black background, which is disagreeable. I have overwritten it with a slightly less flashy (pale yellow) color to make it easier on the eyes.
Unfortunately, this required modifications in a number of diagrams that used a white background on some elements.
Note that the automatic preview does not include the images, ie, the effects of the PR can be checked only by downloading the branch.
Preview | Diff