Skip to content

Updated vsso [instances, annotation]#41

Open
danielwilms wants to merge 3 commits intow3c:gh-pagesfrom
danielwilms:vsso-update-220516
Open

Updated vsso [instances, annotation]#41
danielwilms wants to merge 3 commits intow3c:gh-pagesfrom
danielwilms:vsso-update-220516

Conversation

@danielwilms
Copy link
Copy Markdown
Contributor

@danielwilms danielwilms commented May 16, 2022

Output of new tooling in COVESA/vss-tools#160

  • DVP now instances
  • use of skos:definition instead of rdfs:comment
  • rdfs:comment where vss uses comments (new in 3.0)
  • dot notated path in separate annotation property

Signed-off-by: Daniel Wilms Daniel.DW.Wilms@bmw.de

@danielwilms
Updated vsso [instances, annotation]
e7e4158 
Output of new tooling in COVESA/vss-tools#160

- DVP now instances
- use of `skos:definition` instead of `rdfs:comment`
- `rdfs:comment` where vss uses comments (new in 3.0)
- dot notated path in separate annotation property

Signed-off-by: Daniel Wilms <Daniel.DW.Wilms@bmw.de>
@felix-loesch
Copy link
Copy Markdown

felix-loesch commented May 16, 2022

Great to see that DVP are now instances!

Can we add the linkage from the DVP instance to the VehicleComponent? For example, vsso-signals:EngineCoolantTemp vsso-core:belongsToVehicleComponent vsso-signal:Engine)

@danielwilms
Copy link
Copy Markdown
Contributor Author

danielwilms commented May 16, 2022

@felix-loesch, that's something we have to discuss later. It's possible only, if we instantiate the vehicle components as well...So I decided yesterday to discuss it first, before I implement it.

@danielwilms
Copy link
Copy Markdown
Contributor Author

danielwilms commented May 16, 2022

Decision in meeting on 2022/05/16: creating the vehicle components as instances:

  • possible to create subclass structure later on
  • currently not sufficient information in VSS to have sub-classes in generation
  • work well together with DVP as instances

@danielwilms
[VSSo] Vehicle components as instances
f707960 
`Branch`es of VSS are now modeled as instances of `vsso-core:VehicleComponent`
and not as `rdfs:subClass` anymore.

Two challenges reside:
1. Shall there be an instance of `vsso:Vehicle` or punning of `vsso-core:Vehicle`?
   Challenge araises, when you use the `partOf` relationship.
2. Restrictions on Static Vehicle properties.

Signed-off-by: Daniel Wilms <Daniel.DW.Wilms@bmw.de>
@danielwilms
Copy link
Copy Markdown
Contributor Author

danielwilms commented Jun 14, 2022

Meeting 2022/06/13:

Point from the PR:

Shall there be an instance of vsso:Vehicle or punning of vsso-core:Vehicle?
Challenge araises, when you use the partOf relationship.

Option 1: No root instance node of vehicle components
Option 2: Connecting to vsso-core:Vehicle, but then annotation property is necessary
Option 3: Having an instance vsso:Vehicle as über-VehicleComponent as root of the instances

we go for now with option 3 and discuss further.

danielwilms added a commit to danielwilms/vss-tools that referenced this pull request Jun 14, 2022
@danielwilms
Adding vsso:Vehicle as an instance of vsso-core:VehicleComponent
a65d81e 
Change reflecting discussion in:
w3c/vsso#41 (comment)

Signed-off-by: Daniel Wilms <Daniel.DW.Wilms@bmw.de>
erikbosch pushed a commit to COVESA/vss-tools that referenced this pull request Jun 14, 2022
@danielwilms
VSSo: VehicleComponents as instances (#171)
e282e9f 
* VSSo: VehicleComponents as instances

Currently the VehicleComponents were modelled as
subclasses with `rdfs:subclass`. This change introduces
a variable to choose either way until it's decided.

Additionally introduced documentation improvements and
code cleanups.

Mentioned in: w3c/vsso#22

Signed-off-by: Daniel Wilms <Daniel.DW.Wilms@bmw.de>

* Adding `vsso:Vehicle` as an instance of `vsso-core:VehicleComponent`

Change reflecting discussion in:
w3c/vsso#41 (comment)

Signed-off-by: Daniel Wilms <Daniel.DW.Wilms@bmw.de>
@danielwilms
Copy link
Copy Markdown
Contributor Author

danielwilms commented Jun 27, 2022

@danielwilms checks if option3 is implemented. If so, PR can be merged. Otherwise merged after implementation.

@jdacoello
Copy link
Copy Markdown

jdacoello commented Jul 11, 2022

@danielwilms to provide update on status of implementation of option 3.

@danielwilms
Copy link
Copy Markdown
Contributor Author

danielwilms commented Jul 25, 2022

Implementation done. ttl file to be updated.

@danielwilms
Update vss ttl file
488748e 
Updated ttl file, as implemented in vss-tools.
COVESA/vss-tools@c944887

Signed-off-by: Daniel Wilms <Daniel.DW.Wilms@bmw.de>
@danielwilms
Copy link
Copy Markdown
Contributor Author

danielwilms commented Jul 25, 2022 •
edited
Loading

ttl file added. Ready to merge.

Giaccomole pushed a commit to Giaccomole/vss-tools-statistics-py-scripts that referenced this pull request Jul 22, 2025
@danielwilms
VSSo: VehicleComponents as instances (COVESA#171)
3145788 
* VSSo: VehicleComponents as instances

Currently the VehicleComponents were modelled as
subclasses with `rdfs:subclass`. This change introduces
a variable to choose either way until it's decided.

Additionally introduced documentation improvements and
code cleanups.

Mentioned in: w3c/vsso#22

Signed-off-by: Daniel Wilms <Daniel.DW.Wilms@bmw.de>

* Adding `vsso:Vehicle` as an instance of `vsso-core:VehicleComponent`

Change reflecting discussion in:
w3c/vsso#41 (comment)

Signed-off-by: Daniel Wilms <Daniel.DW.Wilms@bmw.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danielwilms @felix-loesch @jdacoello