Conversation
Collaborator
|
1월3일에볼게요 |
Collaborator
Author
|
바텀시트: 원래 구현 맞춰서 수정해야 함 |
JuTaK97
reviewed
Jan 6, 2026
Comment on lines
+81
to
+86
| onDismiss = { | ||
| // 시트가 닫힐 때 수행해야 할 로직은 Route에서 주입할 수밖에 없음 | ||
| scope.launch { | ||
| if (uiState is HomeDrawerUiState.Loaded && (uiState as HomeDrawerUiState.Loaded).homeDrawerBottomSheetType is HomeDrawerBottomSheetType.SelectTheme) { | ||
| timetableViewModel.setPreviewTheme(null) | ||
| } |
Collaborator
There was a problem hiding this comment.
rememberModalBottomSheetState 요런 컴포즈 의존성 있는 상태값들이 만악의 근원 같기도 해
우리는 뷰모델에서 상태관리 일원화하려고 하는데, 얘네의 존재 때문에
- 뷰모델에서 UIEvent 발사 -> UI에서 구독 후 sheetState.hide()
- 그냥 UI에서 자체적 로직으로 sheetState.hide()
이 두 가지 중에 하나만 제한할 수가 없어
Collaborator
There was a problem hiding this comment.
그래도 옛날에는 이런 UI에서 담당하는 로직이 컴포넌트 안쪽에 깊게 박혀 있었지만 지금은 잘 보이는 Route로 끌어올린 것에 일단 만족하긴 해 ㅋㅋ
JuTaK97
reviewed
Jan 6, 2026
Comment on lines
+119
to
+122
| scope.launch { | ||
| timetableViewModel.updateTheme() | ||
| sheetState.hide() | ||
| } |
Collaborator
There was a problem hiding this comment.
아오 이거 hide가 또 suspend 함수네 ㅋㅋ
JuTaK97
reviewed
Jan 14, 2026
Comment on lines
+64
to
+66
| withFrameNanos {} | ||
| withFrameNanos {} | ||
| withFrameNanos {} // FIXME: 안전한가?? |
Collaborator
There was a problem hiding this comment.
ㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋ 아 이거 진짜 어떡하지
This was referenced Feb 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.