Add warning regarding title field in index#75
Open
fabienheureux wants to merge 2 commits intowagtail:mainfrom
Open
Add warning regarding title field in index#75fabienheureux wants to merge 2 commits intowagtail:mainfrom
fabienheureux wants to merge 2 commits intowagtail:mainfrom
Conversation
175ae76 to
9118988
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add W005 warning when
SearchField("title")is missingSummary
I noticed (accidentally) that
titlefield name is special in Django ModelSearch: aSearchFieldnamed"title"populates a dedicated title index column used for ranking. If no such field is declared, the title column is silently left empty, degrading search quality with no indication to the developer.This PR adds a system check warning (
modelsearch.W005) that fires when a model defines at least oneSearchFieldbut none of them is named"title".I think this is a wagtail's legacy where title is always defined
Example warning output