Add regression test for unpublish publish with inlines#14134
Draft
tomkins wants to merge 1 commit intowagtail:mainfrom
Draft
Add regression test for unpublish publish with inlines#14134tomkins wants to merge 1 commit intowagtail:mainfrom
tomkins wants to merge 1 commit intowagtail:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13332
Fixes #13701 (duplicate)
See: wagtail/django-modelcluster#207
Description
Adds a test for Wagtail to the following scenario:
'pk': Nonefor this inline)For this particular test we see a duplicate without the fix (#13701), if there's inlines with unique constraints then you'll get an IntegrityError (#13332). To avoid adding more models to the test app, I've just kept it to an existing model/inline, so we're just testing to avoid duplicate inlines.
To test:
Results in:
Then:
Success!
Anyway, this all assumes that wagtail/django-modelcluster#207 is the right fix, and a new version of django-modelcluster is needed before this PR can be merged.
Additional testing instructions in that PR which can be done for a Wagtail project.
AI usage
Used Claude Haiku a while ago on this to get started, but it's probably significantly rewritten since then