Skip to content

Conversation

@daurnimator
Copy link
Collaborator

@daurnimator daurnimator commented Nov 14, 2016

  • In :checktls() the inner code previously redeclared the same locals, shadowing the upvalues.
  • TLS 'pushback' data wasn't freed until the whole socket object was. free() it after it has been read.

The inner code previously redeclared the same locals, shadowing the upvalues.

This commit takes out the redundant code rather than removing the shadowing declaration as I'd like to support installing luaossl while a long-running cqueues program is running and have it automatically picked up.
@daurnimator daurnimator changed the title src/socket.lua: Remove dead code in socket:checktls() Some small code cleanups Nov 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant