Skip to content

Adds a Swift Proxy log normalizer#4

Open
joehakimrahme wants to merge 3 commits intowallix:masterfrom
joehakimrahme:master
Open

Adds a Swift Proxy log normalizer#4
joehakimrahme wants to merge 3 commits intowallix:masterfrom
joehakimrahme:master

Conversation

@joehakimrahme
Copy link

Following the description of the log available in the documentation.

Joe H. Rahme added 3 commits June 21, 2013 11:41
According to the doc "-" means 0 bytes transmitted. Accordingly the parser
should insert 0 in the log dictionary.
@morucci
Copy link
Contributor

morucci commented Jun 22, 2013

hi,
Nice thx for this contrib !
It would be cool if you can add at least one example in your parser XML definition like all other parsers (have a look here https://github.com/wallix/pylogsparser/blob/master/normalizers/apache.xml#L229). Thoses examples will be processed by unitests by adding a test method like this one https://github.com/wallix/pylogsparser/blob/master/tests/test_normalizer.py#L47.
Furthermore to detect conflict between parsers it would be cool to add an additional test in this file : https://github.com/wallix/pylogsparser/blob/master/tests/test_log_samples.py

@morucci
Copy link
Contributor

morucci commented Jun 22, 2013

I can't merge as I'm not a Wallix org member since I leave. I don't know about mhu. Maybe Lahoucine will be able to merge your contrib. Or should we fork that project in our account ???

@joehakimrahme
Copy link
Author

Hey Fabien, thanks for the feedback.

I'm going to add the examples and tests as you suggest, so maybe Wallix should wait a bit before accepting this pull request. Hopefully I'll find some time to do it this week.

As far as taking over the project to our account, are you sure you want to do this?

@morucci
Copy link
Contributor

morucci commented Jun 24, 2013

By cloning the project we'll be able to accept pull requests quickly. Maybe you can ask mhu, what he is thinking about :)

@mhu-zz
Copy link
Contributor

mhu-zz commented Jun 24, 2013

There's a big shiny "pull request" button on my interface so I should be able to merge it from here. But as far as I remember this repo is synchronized with a private one @wallix that acts as the reference. I am not sure how merging from github will impact their private repo.
Cloning is always a possibility, though there might be some conflicts if we want to push the clone to PyPI and so on.

@mhu-zz
Copy link
Contributor

mhu-zz commented Jun 24, 2013

It'd be nice if you could modify some of the tag names you use according to the best practices : https://github.com/wallix/pylogsparser#tag-naming-convention

I'd also suggest renaming the "tenant" tag into "tenant_id".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants