Adds a Swift Proxy log normalizer#4
Adds a Swift Proxy log normalizer#4joehakimrahme wants to merge 3 commits intowallix:masterfrom joehakimrahme:master
Conversation
According to the doc "-" means 0 bytes transmitted. Accordingly the parser should insert 0 in the log dictionary.
|
hi, |
|
I can't merge as I'm not a Wallix org member since I leave. I don't know about mhu. Maybe Lahoucine will be able to merge your contrib. Or should we fork that project in our account ??? |
|
Hey Fabien, thanks for the feedback. I'm going to add the examples and tests as you suggest, so maybe Wallix should wait a bit before accepting this pull request. Hopefully I'll find some time to do it this week. As far as taking over the project to our account, are you sure you want to do this? |
|
By cloning the project we'll be able to accept pull requests quickly. Maybe you can ask mhu, what he is thinking about :) |
|
There's a big shiny "pull request" button on my interface so I should be able to merge it from here. But as far as I remember this repo is synchronized with a private one @wallix that acts as the reference. I am not sure how merging from github will impact their private repo. |
|
It'd be nice if you could modify some of the tag names you use according to the best practices : https://github.com/wallix/pylogsparser#tag-naming-convention I'd also suggest renaming the "tenant" tag into "tenant_id". |
Following the description of the log available in the documentation.