Reuse SDK classes instead of duplicating them#35
Merged
orpiske merged 2 commits intowanaku-ai:mainfrom Apr 10, 2026
Merged
Conversation
Replace 16 classes duplicated from wanaku-capabilities-java-sdk with imports from the new capabilities-runtimes-camel-common module. Refactor TarBz2Downloader to a standalone class and simplify CodeGenDiscoveryCallback to use it directly, eliminating the CODEGEN_PACKAGE type incompatibility.
The 0.1.0 release uses capabilities-runtime-camel-common (singular), managed by the BOM, so no explicit version needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
capabilities-runtimes-camel-commonSDK module (+34 lines, -865 lines)TarBz2Downloaderto a standalone class withdownloadAndExtract(URI)API, eliminating theCODEGEN_PACKAGEtype incompatibility with the SDK'sResourceTypeenumWanakuCamelManagerto account for the SDK'sWanakuRoutesLoadersilently catching exceptionsTest plan
mvn clean compilepassesmvn verifypasses (54 tests, 0 failures)