-
Notifications
You must be signed in to change notification settings - Fork 28
Add workspace view with dual terminals to TUI #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vanpelt
wants to merge
27
commits into
main
Choose a base branch
from
feature/tui-workspace-view
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #110 +/- ##
==========================================
- Coverage 11.16% 10.77% -0.40%
==========================================
Files 74 75 +1
Lines 18484 19159 +675
==========================================
Hits 2064 2064
- Misses 16215 16890 +675
Partials 205 205
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fix TUI workspace list to update in real-time via SSE events
The sync mechanism was failing because it was checking for branch existence and updating branches in the worktree path instead of the main repository. Since worktrees use custom refs (refs/catnip/*), they don't have access to regular branches like 'fix/tui-workspace-live-updates'. Key changes: - syncToNiceBranch: Check branch existence in main repo, not worktree - syncToNiceBranch: Update branches in main repo, not worktree - hasUnsyncedNiceBranch: Check branch existence and get hashes from main repo - Remove duplicate findRepositoryForWorktree call in syncToNiceBranch This resolves the "No commits between feature/tui-workspace-view and fix/tui-workspace-live-updates" error when creating PRs, as the nice branches are now properly kept in sync with their custom refs. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Move JSON filtering from view layer to PTY client WebSocket handling - Separate text (JSON control) and binary (PTY output) message processing - Fix sidebar width to use fixed columns (20-30) instead of percentage - Remove unused JSON filtering code from workspace view - Simplify terminal output processing at view layer - Add terminal emulator support for proper ANSI handling - Remove unused functions and fix lint issues 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduced a new workspace-centric view to the TUI that provides a dedicated environment for working with individual project workspaces. This replaces the previous ports-focused overview with a more comprehensive workspace management system.
Key Changes
Ctrl+Wmodal for selecting between workspaces, similar to the existing port selector pattern?agent=claudeparameterImplementation Notes
The workspace view follows the existing TUI architecture patterns, implementing the standard
Viewinterface and integrating with the current message handling system. Mock workspace data is currently provided for development, with the structure ready for API integration.