Skip to content

[ubuntu] add aws ami source #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
jojand wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[ubuntu] add aws ami source #1

jojand wants to merge 2 commits into from

Conversation

@jojand
Copy link
Collaborator

@jojand jojand commented Dec 13, 2023 •
edited
Loading

Description

New tool, Bug fixing, or Improvement?
Please include a summary of the change and which issue is fixed. Also include relevant motivation and context.
For new tools, please provide total size and installation time.

Related issue:

Check list

  • Related issue / work item is attached
  • Tests are written (if applicable)
  • Documentation is updated (if applicable)
  • Changes are tested and related VM images are successfully generated

jojand
jojand commented Dec 13, 2023
View reviewed changes
jojand
jojand commented Dec 13, 2023
View reviewed changes
jojand
jojand commented Dec 13, 2023
View reviewed changes
images/ubuntu/templates/ubuntu-22.04.pkr.hcl Outdated
Copy link
Collaborator Author

@jojand jojand Dec 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new source for aws ami source

jojand
jojand commented Dec 13, 2023
View reviewed changes
images/ubuntu/templates/ubuntu-22.04.pkr.hcl Outdated
Copy link
Collaborator Author

@jojand jojand Dec 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

input as variable with default value for backward compatibility reasons
azure is always build as default if no sources variable is provided

jojand
jojand commented Dec 13, 2023
View reviewed changes
images/ubuntu/templates/ubuntu-22.04.pkr.hcl Outdated
Copy link
Collaborator Author

@jojand jojand Dec 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

input as variable with default value for backward compatibility reasons
azure is always build as default if no sources variable is provided

@jojand jojand force-pushed the add-ami-support branch 2 times, most recently from 7f820d6 to 2ff6585 Compare December 18, 2023 12:42
ostefek99
ostefek99 suggested changes Jan 4, 2024
View reviewed changes
@ostefek99
Copy link

ostefek99 commented Jan 4, 2024

And please use packer fmt <file>. 🙏🏻

ostefek99
ostefek99 suggested changes Jan 4, 2024
View reviewed changes
@jojand
Copy link
Collaborator Author

jojand commented Jan 8, 2024

And please use packer fmt <file>. 🙏🏻

applied for my changes

@jojand jojand requested a review from ostefek99 January 8, 2024 15:21
ostefek99
ostefek99 suggested changes Jan 9, 2024
View reviewed changes
@jojand jojand requested a review from ostefek99 January 9, 2024 13:00
ostefek99
ostefek99 previously approved these changes Jan 9, 2024
View reviewed changes
@jizi jizi force-pushed the add-ami-support branch 2 times, most recently from a6f3337 to d2d7da4 Compare January 19, 2024 15:41
@jizi jizi force-pushed the add-ami-support branch 2 times, most recently from e7f8bd4 to 599286c Compare February 13, 2024 13:45
@jizi jizi force-pushed the add-ami-support branch from 599286c to f7aac0e Compare March 14, 2024 10:59
@jojand jojand marked this pull request as draft August 26, 2024 09:02
@jizi jizi force-pushed the add-ami-support branch 2 times, most recently from be13ab6 to 1058c9b Compare August 29, 2024 09:24
@jizi jizi force-pushed the add-ami-support branch from 0c88c20 to 34dcb4b Compare March 6, 2025 05:56
@jizi jizi force-pushed the add-ami-support branch from e4e6ca7 to 3e52167 Compare May 7, 2025 08:58
@jizi jizi force-pushed the add-ami-support branch from 3e52167 to 34f5806 Compare May 21, 2025 05:54
@jizi jizi force-pushed the add-ami-support branch from 34f5806 to 1e7a333 Compare June 4, 2025 07:03
@martinvizvary martinvizvary force-pushed the add-ami-support branch 2 times, most recently from 7a8850c to 1e7a333 Compare July 24, 2025 09:00
@deynekas deynekas force-pushed the add-ami-support branch 2 times, most recently from 7e7b23d to 4c8c9d7 Compare August 12, 2025 11:48
@jizi jizi force-pushed the add-ami-support branch 2 times, most recently from 7278092 to fb610c8 Compare September 25, 2025 05:31
@jizi jizi force-pushed the add-ami-support branch from ce392a9 to 727cf0b Compare January 8, 2026 11:12
@deynekas @jizi
[jamf][ubuntu] add ami support for ubuntu
515b8ec 
[jamf][ubuntu] Refactor packer templates based on upstream

[jamf][ubuntu] set volume type to gp3

[jamf][ubuntu] add ami support for ubuntu 24

[jamf][ubuntu] do not install miniconda due to license issues

[jamf][ubuntu] add amazon required plugin

[jamf][ubuntu] refactor script

[jamf][ubuntu] packer fmt

[jamf]ubuntu] add amazon-ebs.ubuntu-base-2204 source

[jamf][ubuntu] waagent specific provisioner to be run only on azure-arm.build_image

[jamf][ubuntu] move azure-arm specific configuration into configure-environment-azure-arm.sh

Updating readme file for ubuntu24 version 20250330.1.1
@jizi jizi force-pushed the add-ami-support branch from 727cf0b to 515b8ec Compare January 8, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ostefek99 ostefek99 ostefek99 left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jojand @ostefek99 @deynekas