Conversation
|
Hi there, thanks for sending a pull request! I notice that the CI build failed on Travis, and we only accept pull requests that have passing tests. Do you think you could fix the build, and then add tests for this feature? Additionally, could you tell us about why you need to add this feature? It may be possible to accomplish your goals without needing to change the counter cache in such a low-level way. Thanks! |
|
Hello, I did not find a clear way to pass custom arguments (with Procs) to the worker so I whipped my own. If there's a way to achieve this without new code, please let me know! If not, I'll write some tests grumble grumble. Thanks! |
|
I'm curious about why you need to pass the email into the worker? You should have relation_id in the options hash which would let you perform a lookup against the user with the counter. |
|
If you use scopes for a multi tenant solution in an app, you'll need to pass a tenant_id to the workers. |
|
I see, that makes sense. Let me think about this for a few days and get back to you. Also, half those broken specs are caused by a newer version of rails and were legitimate. I fixed those on master and will release a new version of the gem. The documentation is also updated to describe how to actually run specs 😊 |
2 participants
No description provided.