Improves interoperability for OCR-related data types #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added PartialEq (and Eq, Hash, Clone, Copy where appropriate) to Point, BoundingBox, Resolution, OcrOptions, and OcrWord structs to enable value comparisons and usage in collections. This improves testability and interoperability for OCR-related data types.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request enhances the interoperability of OCR-related data types by adding essential trait derivations (PartialEq, Eq, Hash, and Clone) to core structs, enabling them to be used in collections and comparison operations.
- Added equality and hash traits to
ResolutionandOcrOptionsstructs for use in hash-based collections - Added equality traits to geometric types (
PointandBoundingBox) for comparison operations - Added
CloneandPartialEqtraits toOcrWordfor enhanced usability
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/ocr_options.rs | Added PartialEq, Eq, and Hash to Resolution and OcrOptions structs |
| src/bounding_box.rs | Added PartialEq to Point and BoundingBox structs |
| src/ocr_word.rs | Added Clone and PartialEq to OcrWord struct |
Remove the `Copy` trait from the' OcrOptions' struct, as it may contain non-Copy fields in the future. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes to improve the consistency and usability of data structures in the codebase by adding new trait derivations. The most notable changes include adding
PartialEq,Eq, andHashimplementations to several structs, which enhances their comparability and usability in collections likeHashSetorHashMap.Enhancements to struct trait derivations:
src/bounding_box.rs:PartialEqto thePointstruct, enabling direct equality comparisons betweenPointinstances.PartialEqto theBoundingBoxstruct, allowing equality checks for bounding boxes.src/ocr_options.rs:PartialEq,Eq, andHashto theResolutionstruct, making it usable in hashed collections and comparable for equality.PartialEq,Eq, andHashto theOcrOptionsstruct, improving its usability in contexts requiring equality checks or hashing.src/ocr_word.rs:CloneandPartialEqto theOcrWordstruct, enabling cloning and equality comparisons for OCR word instances.