Replace submodule with cargo patch #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhanced error handling by adding context messages to errors when reading USN and MFT entries. This provides clearer diagnostics when failures occur during iteration.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces a Git submodule dependency with a Cargo path dependency that references the same GitHub repository. This modernizes the dependency management approach by using Cargo's patch mechanism instead of Git submodules.
- Removes the Git submodule
usn-journal-rsand its configuration - Updates Cargo.toml to use a direct version dependency with a Git patch
- Improves error handling by adding proper context to iterator results
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| usn-journal-rs | Removes the Git submodule reference |
| .gitmodules | Removes Git submodule configuration |
| Cargo.toml | Changes from path dependency to version dependency with Git patch |
| src/main.rs | Adds error context handling for iterator results |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
wangfu91
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.