Conversation
…mon evolutions nowadays that it is making it impossible to count for all the edge cases when accessing the API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I really enjoyed working with this API. It was a lot more complex than I imagined, in which I found very rewarding.
I gave myself the suggested time-limit for working on this project, so I didn't get to pursue building some one of the target goals.
The API only allows for users to search by its National Pokedex ID, and you can do that on this app by getting your favorite monster's ID from the website below. I really wanted to be able to search by name since some people may only know their favorite creatures' numbers if at all. I was in the middle of writing methods that would have allowed for that functionality which works in the terminal output, but I didn't get around to incorporating that feature fully in this project. I plan on re-visiting this to be able to search by its name since it would be much more user-friendly.
The intricacies of the Pokemon world made this pretty challenging, especially with Pokemon types. It's pretty basic to include all of the Pokemon's types. However, it would throw an error if we queried for a Pokemon that only had one. Thus, the conditional block starting on line 45 in pokedex_controller.rb is a little redundant because it was a workaround to avoid errors. Any suggestions on how this could be improved would be great.
Thanks!
http://bulbapedia.bulbagarden.net/wiki/List_of_Pok%C3%A9mon_by_National_Pok%C3%A9dex_number