Add isValid callback prop to allow locking dates#17
Open
rstrand wants to merge 1 commit intowangzuo:masterfrom
Open
Add isValid callback prop to allow locking dates#17rstrand wants to merge 1 commit intowangzuo:masterfrom
rstrand wants to merge 1 commit intowangzuo:masterfrom
Conversation
aikar
added a commit
to aikar/input-moment
that referenced
this pull request
Feb 24, 2017
Had to reimplement, but appears to work
|
@rstrand note there is a behavior change in this implementation, in that currently the moment object that's been passed in gets mutated vs cloned. Now, i dont know if the author intends/desires the mutation aspect. however, I updated this logic into the latest input-moment, and can be found here: And also preserves the mutation logic by only cloning on test cases and doesnt use the state for month as you were doing. @wangzuo this is a pretty critical functionality need for any user of this component, so i hope you can get my version in (As i said in the other issue, i'm under super time crunch mode so i dont have the time to split my changes into separate PR's) |
94a097b to
748c7d9
Compare
Author
|
I've rebased this pull request on the current master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added an isValid callback which enables you to lock certain dates. This should be part of what issue #2 is asking.
I have had to change the standard behaviour slightly so that changing the month in the calendar view doesn't automatically update the date selected by the component until you actually click on a new date. This is to avoid a locked date becoming selected when the month is changed and allow you to navigate through an entirely locked month.
The isValid callback should look something like this: