Skip to content

build: remove unused dockerfile and docker-compose#1649

Merged
Pitasi merged 2 commits intomainfrom
cleanup-build-scripts
Aug 25, 2025
Merged

build: remove unused dockerfile and docker-compose#1649
Pitasi merged 2 commits intomainfrom
cleanup-build-scripts

Conversation

@Pitasi
Copy link
Contributor

@Pitasi Pitasi commented Aug 6, 2025

removing some old stuff, and avoiding deploying cosmwasm contracts by default on localnet since we are not using them 99.9% of the times

@Pitasi Pitasi requested review from a team as code owners August 6, 2025 14:49
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 6, 2025

📝 Walkthrough

Walkthrough

All Docker build and runtime instructions for Go-based components were removed from the Dockerfile, leaving only the Node.js build environment setup. The docker-compose.yml file, previously defining multiple interconnected services, was deleted. The localnet.just script was updated to add an optional contract deployment flag and two new governance parameters.

Changes

Cohort / File(s) Change Summary
Dockerfile: Go-based build and runtime removal
Dockerfile
Removed all multi-stage Docker build targets and runtime instructions for Go-based components (wardend, faucet, wardenkms, etc.), retaining only the Node.js build environment setup.
Docker Compose configuration
docker-compose.yml
Deleted the entire Docker Compose file, removing all service definitions and configurations for local development and testing.
Localnet script enhancements
localnet.just
Added an optional deploy-contracts parameter to the start command, introduced two new governance parameters (voting_period, expedited_voting_period), and updated logic to conditionally skip contract deployment.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant localnet.just

    User->>localnet.just: start(deploy-contracts)
    alt deploy-contracts == "false"
        localnet.just-->>User: Skip contract deployment
    else deploy-contracts == "true"
        localnet.just->>localnet.just: Deploy contracts
    end
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~15 minutes

Possibly related PRs

Suggested labels

spaceward, contracts

Suggested reviewers

  • mn13

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1cc0760 and ba95b69.

📒 Files selected for processing (3)
  • Dockerfile (0 hunks)
  • docker-compose.yml (0 hunks)
  • localnet.just (2 hunks)
💤 Files with no reviewable changes (2)
  • docker-compose.yml
  • Dockerfile
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: Svetomech
PR: warden-protocol/wardenprotocol#1133
File: solidity/orders/script/Deploy.s.sol:0-0
Timestamp: 2024-12-13T11:38:18.443Z
Learning: In `solidity/orders/script/Deploy.s.sol`, environment variables for salts (`REGISTRY_SALT` and `FACTORY_SALT`) are not needed for contract deployment; default salts are acceptable in this context.
📚 Learning: in `solidity/orders/script/deploy.s.sol`, environment variables for salts (`registry_salt` and `fact...
Learnt from: Svetomech
PR: warden-protocol/wardenprotocol#1133
File: solidity/orders/script/Deploy.s.sol:0-0
Timestamp: 2024-12-13T11:38:18.443Z
Learning: In `solidity/orders/script/Deploy.s.sol`, environment variables for salts (`REGISTRY_SALT` and `FACTORY_SALT`) are not needed for contract deployment; default salts are acceptable in this context.

Applied to files:

  • localnet.just
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: Analyze (go)
🔇 Additional comments (3)
localnet.just (3)

10-10: Good addition of optional contract deployment control.

The new deploy-contracts parameter with a default value of "false" provides fine-grained control over the localnet startup process, allowing users to skip contract deployment when not needed (which aligns with the PR objective that contracts are rarely used).


68-69: Appropriate governance parameter configuration for local development.

The shortened voting periods (30s for regular voting and 15s for expedited voting) are well-suited for local development and testing scenarios, providing faster feedback cycles compared to mainnet configurations.


72-74: Clean implementation of conditional contract deployment.

The early return pattern effectively skips contract deployment when deploy-contracts is "false", which is consistent with the PR's goal of optimizing the localnet setup by avoiding unnecessary deployments.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch cleanup-build-scripts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Pitasi Pitasi merged commit b1189f4 into main Aug 25, 2025
12 checks passed
@Pitasi Pitasi deleted the cleanup-build-scripts branch August 25, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant