Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions bash/.bashrc
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,7 @@ eval "$(/usr/local/bin/brew shellenv)"



# Machine-local overrides (survives devbox global pull)
[ -f ~/.bashrc.local ] && source ~/.bashrc.local
Comment on lines +6 to +7
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR adds sourcing of ~/.bashrc.local, which is unrelated to the stated PR goal (CUDA-enabled btop via Nix/Devbox). Either update the PR description to cover this additional behavior change, or move it into a separate PR to keep scope focused.

Copilot uses AI. Check for mistakes.

echo "Running .bashrc Scripts... Complete"
3 changes: 2 additions & 1 deletion chezmoi/dot_zshrc
Original file line number Diff line number Diff line change
Expand Up @@ -47,4 +47,5 @@ fi
eval "$(direnv hook zsh)"
test -e "$HOME/.shellfishrc" && source "$HOME/.shellfishrc"


# Machine-local overrides (not managed by chezmoi, survives devbox global pull)
[ -f ~/.zshrc.local ] && source ~/.zshrc.local
Comment on lines +50 to +51
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR adds sourcing of ~/.zshrc.local, which is unrelated to the stated PR goal (CUDA-enabled btop via Nix/Devbox). Either update the PR description to cover this additional behavior change, or move it into a separate PR to keep scope focused.

Copilot uses AI. Check for mistakes.
4 changes: 2 additions & 2 deletions devbox.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"cmatrix@latest",
"atuin@latest",
"bat@latest",
"btop@latest",
"path:./#btop-gpu",
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

devbox.lock in this repo still pins btop@latest, but devbox.json now depends on path:./#btop-gpu. To keep installs reproducible and avoid confusing diffs for other contributors, regenerate/update the lockfile so it reflects the new dependency graph (or remove the stale btop@latest entry if it’s no longer used).

Suggested change
"path:./#btop-gpu",
"btop@latest",

Copilot uses AI. Check for mistakes.
"chezmoi@latest",
"cloc@latest",
"direnv@latest",
Expand Down Expand Up @@ -95,7 +95,7 @@
"git clone https://github.com/tmux-plugins/tpm ~/.tmux/plugins/tpm"
],
"install-chezmoi": [
"chezmoi purge --force && chezmoi init",
"chezmoi init || true",
"cp -r $(devbox global path)/chezmoi/* $(chezmoi source-path)",
"chezmoi apply --no-pager --progress true"
Comment on lines +98 to 100
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chezmoi init || true will ignore any initialization failure (not just the “already initialized” case), which can mask real problems and lead to cp/apply operating on an unexpected source directory. Prefer an idempotent check (e.g., detect an existing chezmoi source dir / repo) and only ignore the specific non-fatal condition, or fail fast with a clearer error.

Copilot uses AI. Check for mistakes.
],
Expand Down
23 changes: 23 additions & 0 deletions flake.nix
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
{
description = "Custom overrides for Devbox";

inputs = {
nixpkgs.url = "github:nixos/nixpkgs/nixos-unstable";
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This flake introduces an unlocked nixpkgs input, but the PR does not add a flake.lock. Without a lock file, btop-gpu will change over time and may break Devbox installs unpredictably. Add and commit flake.lock so the CUDA-enabled build is reproducible.

Suggested change
nixpkgs.url = "github:nixos/nixpkgs/nixos-unstable";
# Pin nixpkgs to a specific revision for reproducible Devbox installs.
nixpkgs.url = "github:nixos/nixpkgs/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";

Copilot uses AI. Check for mistakes.
};

outputs = { self, nixpkgs }:
let
system = "x86_64-linux";
pkgs = import nixpkgs {
inherit system;
Comment on lines +8 to +12
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

system is hard-coded to x86_64-linux, but this repo/config appears to be used on non-Linux hosts as well (e.g., Homebrew setup in shell rc files). With the current flake outputs, path:./#btop-gpu will fail to evaluate on aarch64-darwin/other systems. Consider generating outputs for multiple systems (e.g., via nixpkgs.lib.genAttrs) and/or using builtins.currentSystem, and make btop-gpu fall back to non-CUDA btop on unsupported systems.

Copilot uses AI. Check for mistakes.
config.allowUnfree = true;
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

config.allowUnfree = true enables all unfree packages for this flake. If the intent is only to allow CUDA-related derivations, consider narrowing this (e.g., allowUnfreePredicate) or making it conditional so the flake doesn't silently broaden licensing scope for unrelated packages.

Suggested change
config.allowUnfree = true;
config.allowUnfreePredicate = pkg: true;

Copilot uses AI. Check for mistakes.
};
in
{
packages.${system} = {
btop-gpu = pkgs.btop.override {
cudaSupport = true;
};
};
};
}