-
Notifications
You must be signed in to change notification settings - Fork 0
Add CUDA support to btop via Nix flake override #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -47,4 +47,5 @@ fi | |
| eval "$(direnv hook zsh)" | ||
| test -e "$HOME/.shellfishrc" && source "$HOME/.shellfishrc" | ||
|
|
||
|
|
||
| # Machine-local overrides (not managed by chezmoi, survives devbox global pull) | ||
| [ -f ~/.zshrc.local ] && source ~/.zshrc.local | ||
|
Comment on lines
+50
to
+51
|
||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -6,7 +6,7 @@ | |||||
| "cmatrix@latest", | ||||||
| "atuin@latest", | ||||||
| "bat@latest", | ||||||
| "btop@latest", | ||||||
| "path:./#btop-gpu", | ||||||
|
||||||
| "path:./#btop-gpu", | |
| "btop@latest", |
Copilot
AI
Feb 11, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chezmoi init || true will ignore any initialization failure (not just the “already initialized” case), which can mask real problems and lead to cp/apply operating on an unexpected source directory. Prefer an idempotent check (e.g., detect an existing chezmoi source dir / repo) and only ignore the specific non-fatal condition, or fail fast with a clearer error.
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,23 @@ | ||||||||
| { | ||||||||
| description = "Custom overrides for Devbox"; | ||||||||
|
|
||||||||
| inputs = { | ||||||||
| nixpkgs.url = "github:nixos/nixpkgs/nixos-unstable"; | ||||||||
|
||||||||
| nixpkgs.url = "github:nixos/nixpkgs/nixos-unstable"; | |
| # Pin nixpkgs to a specific revision for reproducible Devbox installs. | |
| nixpkgs.url = "github:nixos/nixpkgs/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"; |
Copilot
AI
Feb 11, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
system is hard-coded to x86_64-linux, but this repo/config appears to be used on non-Linux hosts as well (e.g., Homebrew setup in shell rc files). With the current flake outputs, path:./#btop-gpu will fail to evaluate on aarch64-darwin/other systems. Consider generating outputs for multiple systems (e.g., via nixpkgs.lib.genAttrs) and/or using builtins.currentSystem, and make btop-gpu fall back to non-CUDA btop on unsupported systems.
Copilot
AI
Feb 11, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
config.allowUnfree = true enables all unfree packages for this flake. If the intent is only to allow CUDA-related derivations, consider narrowing this (e.g., allowUnfreePredicate) or making it conditional so the flake doesn't silently broaden licensing scope for unrelated packages.
| config.allowUnfree = true; | |
| config.allowUnfreePredicate = pkg: true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR adds sourcing of
~/.bashrc.local, which is unrelated to the stated PR goal (CUDA-enabled btop via Nix/Devbox). Either update the PR description to cover this additional behavior change, or move it into a separate PR to keep scope focused.