Conversation
bnavetta
force-pushed
the
ben/remote-1041-pr-review-fails-with-long-diffs-pass-as-file-instead
branch
from
4bdfc7a to
959ba56
Compare
captainsafia
approved these changes
Mar 4, 2026
Collaborator
captainsafia
left a comment
captainsafia
left a comment
There was a problem hiding this comment.
Thanks for root causing and fixing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We pass the prompt as a CLI argument, so it's subject to argument length limits.
With large diffs, this can cause the PR review workflow to fail. To avoid this, we should pass the diff and PR description as files, and instruct the agent to read them. This also gives the agent more options - for example, it can grep over the diff to search for specific changes.
In general, we should support a
--prompt-fileargument in the CLI, but that requires a new client release.Tested by pointing a PR in
warp-serverat the workflow on this branch: https://github.com/warpdotdev/warp-server/actions/runs/22666226757/job/65698537822