Fix doubled-word typos in crates/ comments#9338
Fix doubled-word typos in crates/ comments#9338anshul-garg27 wants to merge 4 commits intowarpdotdev:masterfrom
Conversation
|
I'm starting a first review of this pull request. You can follow along in the session on Warp. I approved this pull request and requested human review from: @vorporeal, @zachbai, @szgupta. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR fixes duplicated-word typos in comments and doc comments across crates without changing executable code.
Concerns
- Non-blocking nit: one edited wasm logger doc comment still says "which the given config" and should read "with the given config".
- Security pass: no security-relevant code or configuration changes were introduced.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve with nits
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
Co-authored-by: oz-for-oss[bot] <277970191+oz-for-oss[bot]@users.noreply.github.com>
|
I'm checking this implementation PR for association with a likely matching ready issue. Powered by Oz |
alokedesai
left a comment
There was a problem hiding this comment.
Thanks for contributing! Warp OSS ftw
Folds in the three doubled-word fixes from warpdotdev#9338 that the author deferred while warpdotdev#9279 was open: "that that", "the the", "the the".
Description
While reading through a few crates I kept noticing duplicated words in comments — "the the", "in in", "to to", "and and", "a a", "that that". A quick
grepturned up 17 of them across 15 files. All edits are in//and///comments — no code, test, or behavior change.Files touched:
crates/settings/src/manager.rscrates/websocket/src/sink_map_err.rscrates/warp_completer/src/completer/suggest/test.rscrates/warp_completer/src/completer/engine/argument/legacy.rscrates/warp_completer/src/completer/engine/argument/v2.rscrates/warp_core/src/ui/color/contrast.rscrates/warp_logging/src/wasm.rscrates/warpui_core/src/core/app.rscrates/warpui_core/src/elements/selectable_area.rscrates/warpui_core/src/elements/flex/mod_test.rscrates/warpui/src/platform/mac/text_layout_test.rscrates/warpui/src/platform/mac/rendering/wgpu/mod.rscrates/warpui/src/platform/app.rscrates/warpui/src/windowing/winit/fonts/font_handle.rscrates/warpui/src/fonts/text_layout_test.rsDistinct from #9318, which sweeps single-word misspellings (Surpress, occassionally, etc.) under
app/. I also skipped the two doubled-word lines incrates/integration/src/test.rssince #9279 is currently editing that file — happy to fold them in if that PR lands first.Testing
Comments-only.