Skip to content

Fix doubled-word typos in crates/ comments#9338

Open
anshul-garg27 wants to merge 4 commits intowarpdotdev:masterfrom
anshul-garg27:fix/doubled-word-typos
Open

Fix doubled-word typos in crates/ comments#9338
anshul-garg27 wants to merge 4 commits intowarpdotdev:masterfrom
anshul-garg27:fix/doubled-word-typos

Conversation

@anshul-garg27
Copy link
Copy Markdown

Description

While reading through a few crates I kept noticing duplicated words in comments — "the the", "in in", "to to", "and and", "a a", "that that". A quick grep turned up 17 of them across 15 files. All edits are in // and /// comments — no code, test, or behavior change.

Files touched:

  • crates/settings/src/manager.rs
  • crates/websocket/src/sink_map_err.rs
  • crates/warp_completer/src/completer/suggest/test.rs
  • crates/warp_completer/src/completer/engine/argument/legacy.rs
  • crates/warp_completer/src/completer/engine/argument/v2.rs
  • crates/warp_core/src/ui/color/contrast.rs
  • crates/warp_logging/src/wasm.rs
  • crates/warpui_core/src/core/app.rs
  • crates/warpui_core/src/elements/selectable_area.rs
  • crates/warpui_core/src/elements/flex/mod_test.rs
  • crates/warpui/src/platform/mac/text_layout_test.rs
  • crates/warpui/src/platform/mac/rendering/wgpu/mod.rs
  • crates/warpui/src/platform/app.rs
  • crates/warpui/src/windowing/winit/fonts/font_handle.rs
  • crates/warpui/src/fonts/text_layout_test.rs

Distinct from #9318, which sweeps single-word misspellings (Surpress, occassionally, etc.) under app/. I also skipped the two doubled-word lines in crates/integration/src/test.rs since #9279 is currently editing that file — happy to fold them in if that PR lands first.

Testing

Comments-only.

@cla-bot cla-bot Bot added the cla-signed label Apr 28, 2026
@oz-for-oss
Copy link
Copy Markdown

oz-for-oss Bot commented Apr 28, 2026

@anshul-garg27

I'm starting a first review of this pull request.

You can follow along in the session on Warp.

I approved this pull request and requested human review from: @vorporeal, @zachbai, @szgupta.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Copy link
Copy Markdown

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR fixes duplicated-word typos in comments and doc comments across crates without changing executable code.

Concerns

  • Non-blocking nit: one edited wasm logger doc comment still says "which the given config" and should read "with the given config".
  • Security pass: no security-relevant code or configuration changes were introduced.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve with nits

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Comment thread crates/warp_logging/src/wasm.rs Outdated
@oz-for-oss oz-for-oss Bot requested review from szgupta, vorporeal and zachbai April 28, 2026 23:30
Co-authored-by: oz-for-oss[bot] <277970191+oz-for-oss[bot]@users.noreply.github.com>
@oz-for-oss
Copy link
Copy Markdown

oz-for-oss Bot commented Apr 28, 2026

@alokedesai

I'm checking this implementation PR for association with a likely matching ready issue.

@anshul-garg27

Powered by Oz

Copy link
Copy Markdown
Member

@alokedesai alokedesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! Warp OSS ftw

waynehoover added a commit to waynehoover/warp that referenced this pull request Apr 29, 2026
Folds in the three doubled-word fixes from warpdotdev#9338 that the author
deferred while warpdotdev#9279 was open: "that that", "the the", "the the".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants