spec: hide Warp icon from the Dock when using Hotkey window#9349
spec: hide Warp icon from the Dock when using Hotkey window#9349oz-for-oss[bot] wants to merge 1 commit intomasterfrom
Conversation
Co-Authored-By: Zach Lloyd <zachlloyd@users.noreply.github.com>
|
@oz-for-oss[bot] I'm starting a first review of this spec-only pull request. You can follow along in the session on Warp. I completed the review and posted feedback on this pull request. Comment I completed the review and posted feedback on this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR adds product and technical specs for a macOS-only, opt-in setting that hides Warp from the Dock while the dedicated Hotkey window workflow is active. The specs define default behavior, recovery safeguards, platform API work, settings/UI integration, telemetry constraints, and validation coverage.
Concerns
- No blocking concerns found. The open UX choices are explicitly bounded, and the technical spec provides feasible implementation paths consistent with the referenced settings, hotkey, and macOS platform layers.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
There was a problem hiding this comment.
Overview
This PR adds product and technical specs for a macOS-only opt-in setting that hides Warp from the Dock when the dedicated Hotkey window workflow is enabled.
Concerns
- The recovery safeguard is based on a configured keybinding, but the current global shortcut registration path can fail without surfacing success to the proposed effective-state logic; the spec should require a successful registration or a visible-Dock fallback.
- The product spec still leaves persistence/sync scope as an open question even though the behavior and tech spec assume storage with existing dedicated Hotkey window settings.
Verdict
Found: 0 critical, 2 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| 7. Warp disappears from the Dock but remains running and responding to the registered global hotkey. | ||
| 8. If the user disables the setting, clears the keybinding, or changes global hotkey mode, the same effective-state code restores regular activation policy and the Dock icon returns. | ||
| ## Risks and mitigations | ||
| 1. Risk: Users can lose their obvious app entry point if the Dock icon is hidden without a working hotkey. Mitigation: effective Dock hiding requires a configured dedicated Hotkey window keybinding and restores the Dock icon when the keybinding is removed. |
There was a problem hiding this comment.
| 2. Validate that non-macOS builds ignore the setting and do not expose macOS-specific UI. | ||
| 3. Validate that settings persistence and restart behavior match the effective-state rules in Behavior 8 through 12. | ||
| ## Open questions | ||
| 1. Should this setting be stored only locally on each machine, or should it sync with the existing dedicated Hotkey window settings? The current product expectation is that it persists with the dedicated Hotkey window settings, while non-macOS clients ignore it. |
There was a problem hiding this comment.
1 participant
Summary
Related issue: #1154
Validation
git diff --check.Conversation: https://app.warp.dev/conversation/7fcceaef-5e61-49c5-947c-c712b879a392
Run: https://oz.warp.dev/runs/019dd6a8-6e80-78e2-bb23-8662b8fdc98f
This PR was generated with Oz.