Fix file path detection across wrapped lines#9356
Fix file path detection across wrapped lines#9356Obed0101 wants to merge 1 commit intowarpdotdev:masterfrom
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @Obed0101 on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment |
|
I'm starting a first review of this pull request. You can follow along in the session on Warp. I approved this pull request and requested human review from: @vorporeal, @alokedesai, @zachbai. Comment I approved this pull request. No matching stakeholder was found for the changed files, so no human reviewers were requested. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR fixes terminal file path detection across soft-wrapped lines by merging adjacent path fragments only when neither side contains a file-link separator, and adds a regression test for hovering on both sides of the wrap boundary.
Concerns
- No blocking correctness, security, error-handling, or performance concerns found in the changed lines.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
There was a problem hiding this comment.
Overview
This PR fixes file path candidate generation across soft-wrapped terminal rows by concatenating adjacent wrapped fragments only when neither side contains a file-link separator. It also adds a regression test covering hover detection on both sides of the wrap boundary.
Concerns
- No blocking correctness or security concerns found in the changed lines.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
1 participant
Description
Fixes #9193.
This updates terminal file path detection so fragments split only by a soft-wrapped terminal line are treated as one continuous path. Fragments are still kept separate when either side contains a file-link separator.
A regression test covers the long wrapped path from the issue and verifies detection from both sides of the wrap boundary.
Testing
cargo fmt --checkcargo test -p warp terminal::model::grid::grid_handler::tests::test_possible_file_paths_across_wrapped_lines --no-default-featuresServer API dependencies
None.
Changelog Entries for Stable
CHANGELOG-BUG-FIX: Fixed long file paths split across wrapped terminal lines not being detected as file links.