Skip to content

Comments

Skip already processed movies#440

Open
MoritzWM wants to merge 1 commit intowarpem:mainfrom
MoritzWM:skip_processed
Open

Skip already processed movies#440
MoritzWM wants to merge 1 commit intowarpem:mainfrom
MoritzWM:skip_processed

Conversation

@MoritzWM
Copy link
Contributor

Hello,

when running fs_motion_and_ctf, all movies are processed no matter what, even if they have already been processed with the same options. This seemed a bit inconvenient for e.g. live processing or continuing processing in case of a timeout, so I implemented a very simple check if a movie can be skipped. So far it's only included in fs_motion_and_ctf and not fs_motion.

Are you open for this functionality?

@alisterburt
Copy link
Contributor

Hi @MoritzWM, thanks for opening this PR! Agree the functionality is useful and currently missing but I don't think we would implement it like this if we were to add it. We write out a file called processed_items.json throughout processing and would likely use this. My gut feeling is that this should be implemented as a general mechanism rather than per job type too... will discuss with Dimitry when he gets back from vacation

@MoritzWM
Copy link
Contributor Author

That makes a lot of sense. Maybe I'll take it as a C# programming exercise to move this into IterateOverItems in BaseCommand, which I guess is where it would belong?

@alisterburt
Copy link
Contributor

You're definitely welcome to do this and it could be cool! Just be aware it may not end up being merged as it might not be the strategy Dimitry had in mind and there are some changes he's working on that touch this part of the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants