Master#http accessor #20
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arbenina
commented
Aug 20, 2015
arbenina
commented
- add an intermediate PSGI that allow a client to communicate with the server running via a web server;
- integration with Log4perl logging system;
- auto build yapp file.
- checksum() is a getter for checksum attr. But in this scope we need to calculate checksum so we should call checksum_file(), because we will save an empty checksum value into DB and than we will fail synchronization on client side.
- host config parameter could be an URI - syncdiff client side could create a POST request if host will be an URI
- use URI package for correct work with different host format; - add URI package in Build.PL - parse PasrseCfg.pm on every build
Improvements: - builds yapp files only by 'build' action
- cut ' and " from TK_STRING token - using 'Net::Domain' instead of 'Sys::Hostname' package - smart Forward package - random port - collecting data about input connections
- more safe Moose attributes; - LWP::UserAgent is friend for chroot now; - single client process == single forward connection
- clean up old connections on start syncdiff-server - improve methods for work with 'connections' table
- runner script is not needed now - add apache configuration file(mod_perl,mod_cgi,mod_fcgi) - move config & db code into true POST condition part
- accept client code moved into eval part - remove dead code - use FILEHANDLE with 'print' family functions
- re-write a raw 'print' to info/debug/warn/error/fatal methods - update package dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.