Skip to content

Conversation

@YOU54F
Copy link

@YOU54F YOU54F commented Nov 29, 2024

Building on #73

This PR provides backwards compatibility for Rack 2, preserving the existing behaviour for Rack 2 users, whilst allowing Rack 3 users to still utilise this project.

#73 would fail on earlier versions of Ruby due to the bundler version being updated. We can relax that restriction to allow users on older and newer versions to proceed

Screenshot 2024-11-29 at 17 37 39

Test runs on Ruby 2.7 through to 3.3, with Rack 2 & 3.

Screenshot 2024-11-29 at 17 39 01

One test is failing with Rack 2, as the code stands in master


Failures:

  1) RackReverseProxy::Middleware as a rack app responds with 404 when the path is not matched
     Failure/Error: get "/"

     NoMethodError:
       undefined method `has_key?' for []:Array
     # ./spec/rack/reverse_proxy_spec.rb:764:in `block (3 levels) in <top (required)>'

master...pact-foundation:rack-reverse-proxy:refs/heads/master-ci

@YOU54F
Copy link
Author

YOU54F commented Oct 21, 2025

We will most likely not be maintaining our fork for much longer, as the gem which relies on it will shortly go into deprecation mode.

I have published the changes to ruby gems to make it easier to confirm, rather than sourcing from git

https://rubygems.org/gems/rack-reverse-proxy-pact

Closing off my changes now, ty

@YOU54F YOU54F closed this Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant