Add Kotlin Multiplatform transcription bridge#45
Merged
Conversation
- Add KMP bridge and native adapters for transcription flows - Wire shared frameworks into the Xcode build - Move transcription policy and model startup logic behind shared code
- Update project overview to reflect shared KMP core - Clarify macOS remains the shipped native app with platform-specific transcription adapters - Note planned Windows and Linux targets
- Pass recovery timing as KotlinDouble in the transcription bridge - Bump shared multiplatform Gradle plugin to 2.3.10 - Refresh repo guidance for the KMP workspace
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4260fcb693
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
...n/kotlin/tech/watzon/pindrop/shared/feature/transcription/SharedTranscriptionOrchestrator.kt
Outdated
Show resolved
Hide resolved
- Track hover on the compact indicator state - Ignore hover while recording, processing, dragging, or in a context menu
- Align recording-start trigger naming across Swift and KMP - Preserve load failure state when local model loading is unsupported - Add tests for dedup bypass and unsupported provider handling
- Wire app and Xcode project to new shared UI KMP modules - Move dashboard, history, and dictionary state into shared presenters - Update related services, tests, and build scripts for the rewrite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shared/Gradle workspace, Kotlin contracts/orchestrators, and associated tests for the shared transcription logic.Testing
PindropTests/for model resolution and transcription service behavior.shared/.justrecipes, but the full app/test suite was not executed in this turn.