Skip to content

Fix #95 - for clang-19,20,21 version #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wavefunction91 merged 3 commits into from
Sep 9, 2025
Merged

Fix #95 - for clang-19,20,21 version #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c5bcef9
fix for clang-19,20,21 version
abagusetty Sep 8, 2025
119e001
Add just clang 19 & 21 into the pipeline for release-only testing
abagusetty Sep 9, 2025
9675011
Set any clang-version to defaults per run
abagusetty Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion .github/workflows/build_and_test_compiler_zoo.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,26 @@ jobs:
image: dbwy/chemistry
strategy:
matrix:
compiler: [ {suite: gnu, version: 12}, {suite: llvm, version: 14} ]
compiler:
- {suite: gnu, version: 12}
- {suite: llvm, version: 14}
- {suite: llvm, version: 19}
- {suite: llvm, version: 21}

steps:
- uses: actions/checkout@v3

- name: Install LLVM toolchain
if: ${{ matrix.compiler.suite == 'llvm' }}
shell: bash
run: |
set -euo pipefail
apt-get update
apt-get install -y wget gnupg lsb-release software-properties-common
wget https://apt.llvm.org/llvm.sh
chmod +x llvm.sh
./llvm.sh ${{ matrix.compiler.version }} -y

- name: Setup Compiler
shell: bash
run: $GITHUB_WORKSPACE/.github/workflows/scripts/compiler_setup.sh
Expand Down
8 changes: 7 additions & 1 deletion .github/workflows/scripts/compiler_setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
#/bin/bash
#!/bin/bash

export CSUITE=$1
export CVER=$2

if [[ "${CSUITE}" == "llvm" ]]
then
# register the specific clang version as an alternative (needed once per version)
update-alternatives --install /usr/bin/clang clang /usr/bin/clang-${CVER} 50
update-alternatives --install /usr/bin/clang++ clang++ /usr/bin/clang++-${CVER} 50
update-alternatives --set clang /usr/bin/clang-${CVER}
update-alternatives --set clang++ /usr/bin/clang++-${CVER}
update-alternatives --install /usr/bin/cc cc /usr/bin/clang 30
Expand All @@ -20,3 +23,6 @@ else
exit 125
fi

echo "Selected compilers:"
echo " cc -> $(command -v cc) | $(cc --version | head -1)"
echo " c++ -> $(command -v c++) | $(c++ --version | head -1)"
9 changes: 7 additions & 2 deletions include/integratorxx/quadratures/radial/radial_transform.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,13 @@ struct RadialTransformQuadrature :
using point_container = typename base_type::point_container;
using weight_container = typename base_type::weight_container;

RadialTransformQuadrature(const RadialTraitsType& traits = RadialTraitsType()) :
base_type(traits) { }
RadialTransformQuadrature(const RadialTraitsType& traits)
: base_type(traits) {}

template<class T = RadialTraitsType,
class = std::enable_if_t<std::is_default_constructible<T>::value>>
RadialTransformQuadrature() : base_type(T{}) {}

RadialTransformQuadrature(const RadialTraits& traits) :
RadialTransformQuadrature(radial_traits_cast<RadialTraitsType>(traits)) { }

Expand Down