Skip to content

Use constant Charnock parameter in Moon formulation for z0 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wlanghans wants to merge 2 commits into
base: wolfgang/rebase_sofar-071124_on_main
Choose a base branch
from
Open

Use constant Charnock parameter in Moon formulation for z0 #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7763af4
This reverts the inclusion of a variable Charnock parameter and simpl…
May 12, 2025
3e2d104
Removed sneaky M from z0
May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions gsmphys/sfc_diff_gfdl.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ subroutine sfc_diff_gfdl(im,ps,u1,v1,t1,q1,z1,
! option 4: Moon et al 2007 under high winds (same as in HiRAM)
ws10m_moon = 2.458 + ustar(i)*(20.255-0.56*ustar(i)) ! Eq(7) Moon et al. 2007
if ( ws10m_moon > 20. ) then
call cal_z0_moon(ws10m_moon, z0, charnock(i))
call cal_z0_moon(ws10m_moon, z0)
z0 = max(min(z0, z0s_max), 1.e-7) ! must apply limiter here
endif
endif
Expand Down Expand Up @@ -481,7 +481,7 @@ end subroutine cal_zt_hwrf17

! =======================================================================

subroutine cal_z0_moon(ws10m, z0, charnock)
subroutine cal_z0_moon(ws10m, z0)
! coded by Kun Gao (Kun.Gao@noaa.gov)
use machine , only : kind_phys
use physcons, grav => con_g
Expand All @@ -490,7 +490,7 @@ subroutine cal_z0_moon(ws10m, z0, charnock)
real(kind=kind_phys) :: ustar_th, z0_adj

real(kind=kind_phys), parameter ::
! & charnock=.014
Copy link
Copy Markdown

@miguelsolanocordoba miguelsolanocordoba May 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wlanghans in the Moon et al. (2007) paper the constants used are charnock=0.0185 (eq. 1 + 8a) and wind_th_moon=12.5 (eq 3-5 + 8a-b). I think this would be good to run by Kun Gao, since he likely changed these from the original formulation based on his own findings.

Copy link
Copy Markdown
Author

@wlanghans wlanghans May 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miguelsolanocordoba Sure, but can we do this in a separate PR? Here, I'm just trying to make sure that the Charnock number is constant. We can ask Kun in the next meeting; sounds good?

& charnock=.014
& wind_th_moon = 20.
&, a = 0.56
&, b = -20.255
Expand Down