Skip to content

fix: issues after security updates#23

Merged
claudiu-muresan-pfa merged 2 commits into1.3.0-waylayfrom
fix/validation-errors
Dec 18, 2025
Merged

fix: issues after security updates#23
claudiu-muresan-pfa merged 2 commits into1.3.0-waylayfrom
fix/validation-errors

Conversation

@claudiu-muresan-pfa
Copy link

@claudiu-muresan-pfa claudiu-muresan-pfa commented Dec 11, 2025

After testing on dev cluster there we're two outstanding problems detected:

@claudiu-muresan-pfa claudiu-muresan-pfa self-assigned this Dec 11, 2025
@claudiu-muresan-pfa claudiu-muresan-pfa changed the title Fix/validation errors fix: issues after security updates Dec 11, 2025
@claudiu-muresan-pfa claudiu-muresan-pfa marked this pull request as ready for review December 15, 2025 11:45
@claudiu-muresan-pfa claudiu-muresan-pfa added the bug Something isn't working label Dec 15, 2025
@claudiu-muresan-pfa claudiu-muresan-pfa requested a review from a team December 17, 2025 15:01
@claudiu-muresan-pfa
Copy link
Author

🙏 I need to get this in before starting to work on new bugs coming from prod after Luca's attempt to deploy a newer Kairosdb release:

"sequenceNumber":0,"timestamp":1765983313359,"nanoseconds":359959154,"level":"ERROR","threadName":"qtp1141059550-40","loggerName":"org.kairosdb.core.datastore.CachedSearchResult","mdc": {},"message":"Error reading next data point.","throwable":{"className":"java.io.IOException","message":"Failed to read string and reset stream","stepArray":[{"className":"org.kairosdb.util.KDataInputStream","methodName":"readUTFLong","fileName":"KDataInputStream.java","lineNumber":67},{"className":"org.kairosdb.core.datapoints.StringDataPointFactory","methodName":"getDataPoint","fileName":"StringDataPointFactory.java","lineNumber":39},{"className":"org.kairosdb.core.GuiceKairosDataPointFactory","methodName":"createDataPoint","fileName":"GuiceKairosDataPointFactory.java","lineNumber":129},{"className":"org.kairosdb.core.datastore.CachedSearchResult$CachedDataPointRow","methodName":"next","fileName":"CachedSearchResult.java","lineNumber":534},{"className":"org.kairosdb.core.datastore.CachedSearchResult$CachedDataPointRow","methodName":"next","fileName":"CachedSearchResult.java","lineNumber":466},{"className":"org.kairosdb.core.datastore.DataPointGroupRowWrapper","methodName":"next","fileName":"DataPointGroupRowWrapper.java","lineNumber":75},{"className":"org.kairosdb.core.datastore.DataPointGroupRowWrapper","methodName":"next","fileName":"DataPointGroupRowWrapper.java","lineNumber":26},{"className":"org.kairosdb.util.TournamentTree","methodName":"addIterator","fileName":"TournamentTree.java","lineNumber":77},{"className":"org.kairosdb.core.datastore.SortingDataPointGroup","methodName":"addIterator","fileName":"SortingDataPointGroup.java","lineNumber":60},{"className":"org.kairosdb.core.datastore.SortingDataPointGroup","methodName":"<init>","fileName":"SortingDataPointGroup.java","lineNumber":54},{"className":"org.kairosdb.core.datastore.KairosDatastore","methodName":"groupByTypeAndTag","fileName":"KairosDatastore.java","lineNumber":372},{"className":"org.kairosdb.core.datastore.KairosDatastore$DatastoreQueryImpl","methodName":"execute","fileName":"KairosDatastore.java","lineNumber":522},{"className":"org.kairosdb.core.http.rest.MetricsResource","methodName":"runQuery","fileName":"MetricsResource.java","lineNumber":528},{"className":"org.kairosdb.core.http.rest.MetricsResource","methodName":"postQuery","fileName":"MetricsResource.java","lineNumber":484},{"className":"jdk.internal.reflect.NativeMethodAccessorImpl","methodName":"invoke0","fileName":"NativeMethodAccessorImpl.java","lineNumber":-2},{"className":"jdk.internal.reflect.NativeMethodAccessorImpl","methodName":"invoke","fileName":"NativeMethodAccessorImpl.java","lineNumber":77},{"className":"jdk.internal.reflect.DelegatingMethodAccessorImpl","methodName":"invoke","fileName":"DelegatingMethodAccessorImpl.java","lineNumber":43},{"className":"java.lang.reflect.Method","methodName":"invoke","fileName":"Method.java","lineNumber":569},{"className":"com.sun.jersey.spi.container.JavaMethodInvokerFactory$1","methodName":"invoke","fileName":"JavaMethodInvokerFactory.java","lineNumber":60},{"className":"com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$ResponseOutInvoker","methodName":"_dispatch","fileName":"AbstractResourceMethodDispatchProvider.java","lineNumber":205},{"className":"com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher","methodName":"dispatch","fileName":"ResourceJavaMethodDispatcher.java","lineNumber":75},{"className":"com.sun.jersey.server.impl.uri.rules.HttpMethodRule","methodName":"accept","fileName":"HttpMethodRule.java","lineNumber":302},{"className":"com.sun.jersey.server.impl.uri.rules.RightHandPathRule","methodName":"accept","fileName":"RightHandPathRule.java","lineNumber":147},{"className":"com.sun.jersey.server.impl.uri.rules.ResourceClassRule","methodName":"accept","fileName":"ResourceClassRule.java","lineNumber":108},{"className":"com.sun.jersey.server.impl.uri.rules.RightHandPathRule","methodName":"accept","fileName":"RightHandPathRule.java","lineNumber":147},{"className":"com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule","methodName":"accept","fileName":"RootResourceClassesRule.java","lineNumber":84},{"className":"com.sun.jersey.server.impl.application.WebApplicationImpl","methodName":"_handleRequest","fileName":"WebApplicationImpl.java","lineNumber":1542},{"className":"com.sun.jersey.server.impl.application.WebApplicationImpl","methodName":"_handleRequest","fileName":"WebApplicationImpl.java","lineNumber":1473},{"className":"com.sun.jersey.server.impl.application.WebApplicationImpl","methodName":"handleRequest","fileName":"WebApplicationImpl.java","lineNumber":1419},{"className":"com.sun.jersey.server.impl.application.WebApplicationImpl","methodName":"handleRequest","fileName":"WebApplicationImpl.java","lineNumber":1409},{"className":"com.sun.jersey.spi.container.servlet.WebComponent","methodName":"service","fileName":"WebComponent.java","lineNumber":409},{"className":"com.sun.jersey.spi.container.servlet.ServletContainer","methodName":"service","fileName":"ServletContainer.java","lineNumber":558},{"className":"com.sun.jersey.spi.container.servlet.ServletContainer","methodName":"service","fileName":"ServletContainer.java","lineNumber":733},{"className":"javax.servlet.http.HttpServlet","methodName":"service","fileName":"HttpServlet.java","lineNumber":790},{"className":"com.google.inject.servlet.ServletDefinition","methodName":"doServiceImpl","fileName":"ServletDefinition.java","lineNumber":290},{"className":"com.google.inject.servlet.ServletDefinition","methodName":"doService","fileName":"ServletDefinition.java","lineNumber":280},{"className":"com.google.inject.servlet.ServletDefinition","methodName":"service","fileName":"ServletDefinition.java","lineNumber":184},{"className":"com.google.inject.servlet.ManagedServletPipeline","methodName":"service","fileName":"ManagedServletPipeline.java","lineNumber":89},{"className":"com.google.inject.servlet.FilterChainInvocation","methodName":"doFilter","fileName":"FilterChainInvocation.java","lineNumber":85},{"className":"org.kairosdb.core.http.MonitorFilter","methodName":"doFilter","fileName":"MonitorFilter.java","lineNumber":81},{"className":"com.google.inject.servlet.FilterChainInvocation","methodName":"doFilter","fileName":"FilterChainInvocation.java","lineNumber":82},{"className":"org.kairosdb.core.http.LoggingFilter","methodName":"doFilter","fileName":"LoggingFilter.java","lineNumber":50},{"className":"com.google.inject.servlet.FilterChainInvocation","methodName":"doFilter","fileName":"FilterChainInvocation.java","lineNumber":82},{"className":"com.google.inject.servlet.ManagedFilterPipeline","methodName":"dispatch","fileName":"ManagedFilterPipeline.java","lineNumber":121},{"className":"com.google.inject.servlet.GuiceFilter","methodName":"doFilter","fileName":"GuiceFilter.java","lineNumber":133},{"className":"org.eclipse.jetty.servlet.ServletHandler$CachedChain","methodName":"doFilter","fileName":"ServletHandler.java","lineNumber":1638},{"className":"org.eclipse.jetty.servlet.ServletHandler","methodName":"doHandle","fileName":"ServletHandler.java","lineNumber":567},{"className":"org.eclipse.jetty.server.handler.ScopedHandler","methodName":"handle","fileName":"ScopedHandler.java","lineNumber":143},{"className":"org.eclipse.jetty.security.SecurityHandler","methodName":"handle","fileName":"SecurityHandler.java","lineNumber":567},{"className":"org.eclipse.jetty.server.handler.HandlerWrapper","methodName":"handle","fileName":"HandlerWrapper.java","lineNumber":127},{"className":"org.eclipse.jetty.server.handler.ScopedHandler","methodName":"nextHandle","fileName":"ScopedHandler.java","lineNumber":235},{"className":"org.eclipse.jetty.server.handler.ContextHandler","methodName":"doHandle","fileName":"ContextHandler.java","lineNumber":1377},{"className":"org.eclipse.jetty.server.handler.ScopedHandler","methodName":"nextScope","fileName":"ScopedHandler.java","lineNumber":188},{"className":"org.eclipse.jetty.servlet.ServletHandler","methodName":"doScope","fileName":"ServletHandler.java","lineNumber":507},{"className":"org.eclipse.jetty.server.handler.ScopedHandler","methodName":"nextScope","fileName":"ScopedHandler.java","lineNumber":186},{"className":"org.eclipse.jetty.server.handler.ContextHandler","methodName":"doScope","fileName":"ContextHandler.java","lineNumber":1292},{"className":"org.eclipse.jetty.server.handler.ScopedHandler","methodName":"handle","fileName":"ScopedHandler.java","lineNumber":141},{"className":"org.eclipse.jetty.server.handler.gzip.GzipHandler","methodName":"handle","fileName":"GzipHandler.java","lineNumber":767},{"className":"org.eclipse.jetty.server.handler.HandlerList","methodName":"handle","fileName":"HandlerList.java","lineNumber":59},{"className":"org.eclipse.jetty.server.handler.HandlerWrapper","methodName":"handle","fileName":"HandlerWrapper.java","lineNumber":127},{"className":"org.eclipse.jetty.server.Server","methodName":"handle","fileName":"Server.java","lineNumber":501},{"className":"org.eclipse.jetty.server.HttpChannel","methodName":"lambda$handle$1","fileName":"HttpChannel.java","lineNumber":383},{"className":"org.eclipse.jetty.server.HttpChannel","methodName":"dispatch","fileName":"HttpChannel.java","lineNumber":556},{"className":"org.eclipse.jetty.server.HttpChannel","methodName":"handle","fileName":"HttpChannel.java","lineNumber":375},{"className":"org.eclipse.jetty.server.HttpConnection","methodName":"onFillable","fileName":"HttpConnection.java","lineNumber":273},{"className":"org.eclipse.jetty.io.AbstractConnection$ReadCallback","methodName":"succeeded","fileName":"AbstractConnection.java","lineNumber":311},{"className":"org.eclipse.jetty.io.FillInterest","methodName":"fillable","fileName":"FillInterest.java","lineNumber":105},{"className":"org.eclipse.jetty.io.ChannelEndPoint$1","methodName":"run","fileName":"ChannelEndPoint.java","lineNumber":104},{"className":"org.eclipse.jetty.util.thread.strategy.EatWhatYouKill","methodName":"runTask","fileName":"EatWhatYouKill.java","lineNumber":336},{"className":"org.eclipse.jetty.util.thread.strategy.EatWhatYouKill","methodName":"doProduce","fileName":"EatWhatYouKill.java","lineNumber":313},{"className":"org.eclipse.jetty.util.thread.strategy.EatWhatYouKill","methodName":"tryProduce","fileName":"EatWhatYouKill.java","lineNumber":171},{"className":"org.eclipse.jetty.util.thread.strategy.EatWhatYouKill","methodName":"run","fileName":"EatWhatYouKill.java","lineNumber":129},{"className":"org.eclipse.jetty.util.thread.ReservedThreadExecutor$ReservedThread","methodName":"run","fileName":"ReservedThreadExecutor.java","lineNumber":375},{"className":"org.eclipse.jetty.util.thread.QueuedThreadPool","methodName":"runJob","fileName":"QueuedThreadPool.java","lineNumber":806},{"className":"org.eclipse.jetty.util.thread.QueuedThreadPool$Runner","methodName":"run","fileName":"QueuedThreadPool.java","lineNumber":938},{"className":"java.lang.Thread","methodName":"run","fileName":"Thread.java","lineNumber":840}],"cause":{"className":"java.io.IOException","message":"Resetting to invalid mark","stepArray":[{"className":"java.io.BufferedInputStream","methodName":"reset","fileName":"BufferedInputStream.java","lineNumber":446},{"className":"java.io.FilterInputStream","methodName":"reset","fileName":"FilterInputStream.java","lineNumber":224},{"className":"org.kairosdb.util.KDataInputStream","methodName":"readUTFLong","fileName":"KDataInputStream.java","lineNumber":48}],"commonFramesCount":75}}}

@claudiu-muresan-pfa
Copy link
Author

@ramazanyich, I need a review for this PR 🙏 before merging #24

@claudiu-muresan-pfa claudiu-muresan-pfa merged commit 28795db into 1.3.0-waylay Dec 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants