fix: array IndexError when center_agent_idx is not set as sdc#50
Open
SS47816 wants to merge 1 commit intowaymo-research:mainfrom
Open
fix: array IndexError when center_agent_idx is not set as sdc#50SS47816 wants to merge 1 commit intowaymo-research:mainfrom
SS47816 wants to merge 1 commit intowaymo-research:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the behavior of the function
plot_simulator_state()when the parametercenter_agent_idxinviz_configis not-1 # sdc.Original Issue
When the parameter
center_agent_idxinviz_configis set to a user-specified index, the following issue will arise:This issue occurred because the shape of the
xy = current_xy[state.object_metadata.is_sdc]is[1, 2](2-dimension) whereas the shape of thexy = current_xy[viz_config.center_agent_idx]is[2](1-dimension).Fix
The following code in
visualization/viz.py, from the line280to294:has been changed to:
so that the shapes of the
origin_x, origin_y, andxyin the if-else statement are now properly aligned.