Skip to content

Conversation

@tarrow
Copy link
Contributor

@tarrow tarrow commented Dec 15, 2025

This patch fixes some unusual behaviour of the composer-merge-plugin that prevents it from installing using the composer.lock file precisely.

Previously we worked around this by installing composer in a standalone environment to prevent it running composer update. Unfortunately this was broken by the new allow-plugins concept and worked around in #489 but this also prevented the install of packages from composer-merge-plugin.

@deer-wmde
Copy link
Contributor

seems like this fixes it! 🎉

Co-authored-by: dena <91744937+deer-wmde@users.noreply.github.com>
@deer-wmde
Copy link
Contributor

So after our chat today I think we want to merge this right?

fwiw I tried running ./sync.sh -u on main and it also runs into the error, so I think we need this

@tarrow
Copy link
Contributor Author

tarrow commented Dec 16, 2025

a) I'm worried how understandable what is going on is: is there a way to make this clearer?
b) does this accidentally reintroduce T302558 ? Can we test and be sure this isn't the case? I'm pretty certain that it's fixed back to what we learned 4 years ago but it would be nice to have some testing or something more concrete to check

@tarrow tarrow marked this pull request as ready for review December 16, 2025 13:20
@tarrow tarrow requested a review from deer-wmde December 16, 2025 13:20
@tarrow
Copy link
Contributor Author

tarrow commented Dec 16, 2025

a) I'm worried how understandable what is going on is: is there a way to make this clearer? b) does this accidentally reintroduce T302558 ? Can we test and be sure this isn't the case? I'm pretty certain that it's fixed back to what we learned 4 years ago but it would be nice to have some testing or something more concrete to check

I have tried to make this much clearer and add links to the upstream solutions that are still out there cooking

@deer-wmde deer-wmde merged commit 96eda52 into main Dec 16, 2025
9 checks passed
@deer-wmde deer-wmde deleted the ta/fix-composer-merge-not-installing-packages branch December 16, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants