updates to eliminate 2d artifacts from difference operations#7
Open
x0pherl wants to merge 1 commit intowbu:masterfrom
Open
updates to eliminate 2d artifacts from difference operations#7x0pherl wants to merge 1 commit intowbu:masterfrom
x0pherl wants to merge 1 commit intowbu:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "difference" operation in openscad creates artifacts on render if the bit you're subtracting doesn't exceed the borders of the bit you are starting with -- it creates a sort of shimmery plane in preview that's pretty annoying (although it doesn't impact the fully rendered part)
I've added a simple fix here that adds 0.01mm of extra size to the parts being subtracted so that rendering artifact goes away.