Increase max lint errors #187
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lint error limit of 999 is preventing use of this dependency in large codebases. I have increased the limit to 9999. This is still a magic and arbitrary number, and it's very possible this limit will need to be revisited in the future.
Author
|
5 months have passed since this PR with no response. Do you accept external contributions? |
Contributor
|
See #167 |
oliverhr
reviewed
Apr 26, 2018
oliverhr
left a comment
oliverhr
left a comment
There was a problem hiding this comment.
Solves the problem, but is too rigid.
Author
|
It is exclusively a reduction in rigidity.. |
oliverhr
added a commit
to oliverhr/swagger-js-codegen
that referenced
this pull request
Apr 26, 2018
resolve wcandillon#187 Increase max lint errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lint error limit of 999 is preventing use of this dependency in large codebases. I have increased the limit to 9999. This is still a magic and arbitrary number, and it's very possible this limit will need to be revisited in the future.