WIP: Adding custom stripe form #64
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CurtisALee
reviewed
Jan 13, 2021
| $font-size-xxs: 0.75rem; | ||
| $font-size-xs: 0.8rem !default; | ||
| $font-size-sm: 0.9rem !default; | ||
| $font-size-sub: 1.05rem !default; |
Contributor
There was a problem hiding this comment.
The new variable here breaks the font-size convention and feels out of place.
I'm also not sure what sub means, and it's not clear to me what size I can expect from it.
If this font-size is only used in one place, could we not consider removing the variable for it completely?
ojsdude
force-pushed
the
adding-custom-stripe-form
branch
4 times, most recently
from
da88466 to
b75b236
Compare
ojsdude
force-pushed
the
adding-custom-stripe-form
branch
from
b75b236 to
1ee4ef5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work includes a new "Payment Form" that we'd like to use to replace the current stripe checkout process.
We will need to use https://stripe.com/en-gb/payments/elements and https://stripe.com/docs/payments/accept-a-payment?integration=elements to get this working properly.
Design-wise we need to:
.loadingto the.payment-formdiv when the form is submitting. Also disable the inputs. Theloadingclass will add opacity to the form-group elements and the loading spinner to the button.