Mark IndexedDB transactions inactive during key serialization#55660
Open
nolanlawson wants to merge 2 commits intomasterfrom
Open
Mark IndexedDB transactions inactive during key serialization#55660nolanlawson wants to merge 2 commits intomasterfrom
nolanlawson wants to merge 2 commits intomasterfrom
Conversation
5 tasks
odinho
approved these changes
Oct 25, 2025
Contributor
odinho
left a comment
odinho
left a comment
There was a problem hiding this comment.
Looks good to me, I see the spec change has an okay already. This should probably go in at the same time the actual change comes in though.
You could probably also link this to the spec text before doing the merge once the spec text is up? Or update it. If w3ctests even use links anymore.
Member
Author
|
Thanks for the review! I just updated the tests based on some feedback in the spec PR: w3c/IndexedDB#479 (comment) . I'll wait for an OK on both PRs before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helps close w3c/IndexedDB#476.
This test is largely based on
structured-clone-transaction-state.any.jsand is designed to match Firefox's implementation. WebKit and Chromium currently fail this test.