Skip to content

fix: cap mobile devicePixelRatio #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
web3dev1337 wants to merge 1 commit into from
Closed

fix: cap mobile devicePixelRatio #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions client/src/core/Renderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,18 @@ import type { NetworkManagerEventPayload } from '../network/NetworkManager';
import { type ClientSettingsEventPayload, ClientSettingsEventType } from '../settings/SettingsManager';

const MISSING_SKYBOX_TEXTURE_PATH = '/textures/missing-skybox';
const IOS_MAX_RENDER_PIXEL_RATIO = 1.5;
const OTHER_MOBILE_MAX_RENDER_PIXEL_RATIO = 2.0;

const isIOSOrIPadOS = (): boolean => {
if (navigator.platform === 'MacIntel' && navigator.maxTouchPoints > 1) {
return true;
}

return /iPad|iPhone|iPod/.test(navigator.userAgent);
};

const MAX_MOBILE_DPR = isIOSOrIPadOS() ? IOS_MAX_RENDER_PIXEL_RATIO : OTHER_MOBILE_MAX_RENDER_PIXEL_RATIO;

// Working variables
const color = new Color();
Expand Down Expand Up @@ -494,7 +506,7 @@ export default class Renderer {
const { resolution } = this._game.settingsManager.qualityPerfTradeoff;

const devicePixelRatio = MobileManager.isMobile
? Math.min(window.devicePixelRatio, 2.0)
? Math.min(window.devicePixelRatio, MAX_MOBILE_DPR)
: window.devicePixelRatio;
this._renderer.setPixelRatio(devicePixelRatio * resolution.multiplier);

Expand Down Expand Up @@ -596,7 +608,7 @@ export default class Renderer {
this._renderer.setSize(document.documentElement.clientWidth, document.documentElement.clientHeight);
const resolutionMultiplier = this._game.settingsManager.qualityPerfTradeoff.resolution.multiplier;
const devicePixelRatio = MobileManager.isMobile
? Math.min(window.devicePixelRatio, 2.0)
? Math.min(window.devicePixelRatio, MAX_MOBILE_DPR)
: window.devicePixelRatio;
this._renderer.setPixelRatio(devicePixelRatio * resolutionMultiplier);
this._renderer.info.autoReset = false;
Expand Down