Skip to content

fix: cap mobile devicePixelRatio #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
web3dev1337 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: cap mobile devicePixelRatio #5

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
80de59e
fix: cap mobile device pixel ratio
web3dev1337 Mar 2, 2026
f7788d4
fix: cap mobile devicePixelRatio
web3dev1337 Mar 4, 2026
5cc5efa
refactor: self-documenting names for mobile DPR safety cap
web3dev1337 Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions client/src/core/Renderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ import Chunk from '../chunks/Chunk';
import Assets from '../network/Assets';
import EventRouter from '../events/EventRouter';
import Game from '../Game';
import MobileManager from '../mobile/MobileManager';
import { modalAlert } from '../ui/Modal';
import { NetworkManagerEventType } from '../network/NetworkManager';
import { getTransparentSortKey, lerpColor } from '../three/utils';
Expand All @@ -41,6 +42,22 @@ import type { NetworkManagerEventPayload } from '../network/NetworkManager';
import { type ClientSettingsEventPayload, ClientSettingsEventType } from '../settings/SettingsManager';

const MISSING_SKYBOX_TEXTURE_PATH = '/textures/missing-skybox';
const SAFE_PIXEL_RATIO_IOS = 1.5;
const SAFE_PIXEL_RATIO_MOBILE = 2.0;

const isAppleMobileDevice = (): boolean => {
if (navigator.platform === 'MacIntel' && navigator.maxTouchPoints > 1) return true;

return /iPad|iPhone|iPod/.test(navigator.userAgent);
};

const safeDevicePixelRatio = (nativeRatio: number): number => {
if (!MobileManager.isMobile) return nativeRatio;

const gpuSafeMax = isAppleMobileDevice() ? SAFE_PIXEL_RATIO_IOS : SAFE_PIXEL_RATIO_MOBILE;

return Math.min(nativeRatio, gpuSafeMax);
};

// Working variables
const color = new Color();
Expand Down Expand Up @@ -492,7 +509,7 @@ export default class Renderer {
private _onClientSettingsUpdate = (_payload: ClientSettingsEventPayload.IUpdate): void => {
const { resolution } = this._game.settingsManager.qualityPerfTradeoff;

this._renderer.setPixelRatio(window.devicePixelRatio * resolution.multiplier);
this._renderer.setPixelRatio(safeDevicePixelRatio(window.devicePixelRatio) * resolution.multiplier);

this._clampTargetFogNearAndFar();
this._setupFog();
Expand Down Expand Up @@ -590,7 +607,8 @@ export default class Renderer {

private _setupRenderer(): void {
this._renderer.setSize(document.documentElement.clientWidth, document.documentElement.clientHeight);
this._renderer.setPixelRatio(window.devicePixelRatio * this._game.settingsManager.qualityPerfTradeoff.resolution.multiplier);
const resolutionMultiplier = this._game.settingsManager.qualityPerfTradeoff.resolution.multiplier;
this._renderer.setPixelRatio(safeDevicePixelRatio(window.devicePixelRatio) * resolutionMultiplier);
this._renderer.info.autoReset = false;
this._renderer.localClippingEnabled = false;
// Be explicit about output space; this is cheap and avoids surprises across Three.js versions.
Expand Down