Mirror upstream PR #10 (stacked): camera tracking smoothing#8
Open
web3dev1337 wants to merge 1 commit intoreview/mirror-upstream-pr-9from
Open
Mirror upstream PR #10 (stacked): camera tracking smoothing#8web3dev1337 wants to merge 1 commit intoreview/mirror-upstream-pr-9from
web3dev1337 wants to merge 1 commit intoreview/mirror-upstream-pr-9from
Conversation
- Introduced new properties for managing attached and tracked camera positions, including targets for smoother transitions. - Implemented logic to snap positions on large jumps and lerp for gradual adjustments. - Updated deserialization handling to ensure mutual exclusivity between tracked entity and position. - Improved camera shoulder rotation handling with a dedicated axis vector.
Owner
Author
Review (camera smoothing)Nice improvement for fixed-camera world-space follow. Smoothing the packet-driven attached/tracked positions and adding snap-on-teleport should eliminate the small jitter you can get when those positions arrive quantized / irregularly. What looks good
Things to double-check (possible behavior changes)
Perf / mobile vs desktop
(Also worth noting upstream PR #10 is stacked on #9; this fork PR is stacked on fork PR #7 to keep the diff focused.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors upstream PR #10 (hytopiagg#10).
Upstream PR #10 is stacked on top of upstream PR #9, so this fork PR is intentionally stacked on top of fork PR #7 to keep the diff limited to the camera smoothing change.
Validation:
npm --prefix client run build