Skip to content

Conversation

@toretre
Copy link

@toretre toretre commented Oct 2, 2025

COMPLETES #< https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-737609 >

This pull request addresses

It seems the '@ciscospark/test-users-legacy' is not referenced in the code base. It was referenced by 'internal-plugin-lyra' some time back, but the update did not remove the declaration of test-users-legacy.

'@ciscospark/test-users-legacy' is an old dependency (not touched in 6 years) and might block dependency upgrades for consuming project. One example is dependency 'requests' which is abandoned and also have many known CVE vulnerabilities attached.

by making the following changes

1.Drop '@ciscospark/test-users-legacy' from the package.json files where it is referenced

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios were tested

< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

The GAI Coding Policy And Copyright Annotation Best Practices

  • GAI was not used (or, no additional notation is required)
  • Code was generated entirely by GAI
  • GAI was used to create a draft that was subsequently customized or modified
  • Coder created a draft manually that was non-substantively modified by GAI (e.g., refactoring was performed by GAI on manually written code)
  • Tool used for AI assistance (GitHub Copilot / Other - specify)
    • Github Copilot
    • Other - Please Specify
  • This PR is related to
    • Feature
    • Defect fix
    • Tech Debt
    • Automation

I certified that

  • I have read and followed contributing guidelines
  • I discussed changes with code owners prior to submitting this pull request
  • I have not skipped any automated checks
  • All existing and new tests passed
  • I have updated the documentation accordingly

Make sure to have followed the contributing guidelines before submitting.

@toretre toretre marked this pull request as ready for review October 2, 2025 18:01
@toretre toretre requested a review from a team as a code owner October 2, 2025 18:01
@arun3528 arun3528 added the validated If the pull request is validated for automation. label Nov 10, 2025
Copy link
Contributor

@mkesavan13 mkesavan13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still mention of this package in one of the test case comments here: https://github.com/toretre/webex-js-sdk/blob/dropdependency/packages/%40webex/internal-plugin-user/test/integration/spec/user.js

Could you please check the comment and ensure it is not a harm for us to remove? If so, let's remove the comment as well and go ahead.

@toretre
Copy link
Author

toretre commented Dec 9, 2025

There's still mention of this package in one of the test case comments here: https://github.com/toretre/webex-js-sdk/blob/dropdependency/packages/%40webex/internal-plugin-user/test/integration/spec/user.js

Could you please check the comment and ensure it is not a harm for us to remove? If so, let's remove the comment as well and go ahead.

I see the out-commented line was done as part of : https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-85832
Commit here : https://github.com/webex/webex-js-sdk/pull/1337/files#diff-082bdd3847119ab79e7e2ccd8bfe8b0150da1633aa3d061f6630d37a476ae1ef

I don't know the history around this change, but maybe we can try enabling the test again and see if a EUUser with federation enabled can successfully pass ?

Seems similar test setup is found in packages/@webex/plugin-authorization-browser-first-party/test/automation/spec/authorization-code-grant.js

Or ask the original committer if he remembers the history ? @InteractiveTimmy

@toretre toretre requested a review from a team as a code owner December 9, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

validated If the pull request is validated for automation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants