Skip to content

Conversation

@marcin-bazyl
Copy link
Collaborator

COMPLETES #SPARK-746275

This pull request addresses

Locus has taken out links out of Locus object and into a separate "links" object.

by making the following changes

Existing code was taking services and resources out of links and copying them onto LocusInfo class, so you would end up with Meeting.locusInfo.services and Meeting.locusInfo.resources, but no Meeting.locusInfo.links. This is inconsistent with how other Locus DTO fiels are handled (like info, fullState, etc) and also would complicate code for hash trees handling, so I've changed it to just copy links from DTO into Meeting.locusInfo.links.

BTW, there is also a piece of code here in Meeting constructor that expects locusInfo.links to exist, but before this PR this would never happen and RecordingController has been working fine only by luck, because we always get at least one Locus update during meeting join, so then it gets the serviceUrl correctly from the LOCUSINFO.EVENTS.LINKS_SERVICES event.

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios where tested

unit tests, manual e2e test with web app and Locus in integration

The GAI Coding Policy And Copyright Annotation Best Practices

  • GAI was not used (or, no additional notation is required)
  • Code was generated entirely by GAI
  • GAI was used to create a draft that was subsequently customized or modified
  • Coder created a draft manually that was non-substantively modified by GAI (e.g., refactoring was performed by GAI on manually written code)
  • Tool used for AI assistance (GitHub Copilot / Other - specify)
    • Github Copilot
    • Other - Please Specify
  • This PR is related to
    • Feature
    • Defect fix
    • Tech Debt
    • Automation

I certified that

  • I have read and followed contributing guidelines

  • I discussed changes with code owners prior to submitting this pull request

  • I have not skipped any automated checks

  • All existing and new tests passed

  • I have updated the documentation accordingly


Make sure to have followed the contributing guidelines before submitting.

@marcin-bazyl marcin-bazyl requested review from a team as code owners December 12, 2025 12:28
@marcin-bazyl marcin-bazyl added the validated If the pull request is validated for automation. label Dec 12, 2025
@aws-amplify-us-east-2
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-4611.d3m3l2kee0btzx.amplifyapp.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

validated If the pull request is validated for automation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants