fix(meetings): added support for links Locus hash tree objects #4611
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPLETES #SPARK-746275
This pull request addresses
Locus has taken out links out of Locus object and into a separate "links" object.
by making the following changes
Existing code was taking services and resources out of links and copying them onto LocusInfo class, so you would end up with
Meeting.locusInfo.servicesandMeeting.locusInfo.resources, but noMeeting.locusInfo.links. This is inconsistent with how other Locus DTO fiels are handled (likeinfo,fullState, etc) and also would complicate code for hash trees handling, so I've changed it to just copylinksfrom DTO intoMeeting.locusInfo.links.BTW, there is also a piece of code here in Meeting constructor that expects
locusInfo.linksto exist, but before this PR this would never happen and RecordingController has been working fine only by luck, because we always get at least one Locus update during meeting join, so then it gets the serviceUrl correctly from theLOCUSINFO.EVENTS.LINKS_SERVICESevent.Change Type
The following scenarios where tested
unit tests, manual e2e test with web app and Locus in integration
The GAI Coding Policy And Copyright Annotation Best Practices
I certified that
I have read and followed contributing guidelines
I discussed changes with code owners prior to submitting this pull request
I have not skipped any automated checks
All existing and new tests passed
I have updated the documentation accordingly
Make sure to have followed the contributing guidelines before submitting.