init project #1
Open
init project #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vm-001
suggested changes
Apr 30, 2025
charts/webhookx/Chart.yaml
Outdated
| @@ -0,0 +1,24 @@ | |||
| apiVersion: v2 | |||
| name: webhookx | |||
| description: A Helm chart for Kubernetes | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| description: A Helm chart for Kubernetes | |
| description: The WebhookX Helm chart |
| @@ -0,0 +1,24 @@ | |||
| apiVersion: v2 | |||
Collaborator
There was a problem hiding this comment.
Please remove all the template comments to make it cleaner.
charts/webhookx/Chart.yaml
Outdated
| # incremented each time you make changes to the application. Versions are not expected to | ||
| # follow Semantic Versioning. They should reflect the version the application is using. | ||
| # It is recommended to use it with quotes. | ||
| appVersion: "1.16.0" |
Collaborator
There was a problem hiding this comment.
Suggested change
| appVersion: "1.16.0" | |
| appVersion: "0.6" |
charts/webhookx/Chart.yaml
Outdated
| # This is the chart version. This version number should be incremented each time you make changes | ||
| # to the chart and its templates, including the app version. | ||
| # Versions are expected to follow Semantic Versioning (https://semver.org/) | ||
| version: 0.1.2 |
Collaborator
There was a problem hiding this comment.
Suggested change
| version: 0.1.2 | |
| version: 0.1.0 |
charts/webhookx/values.yaml
Outdated
| # This sets the pull policy for images. | ||
| pullPolicy: IfNotPresent | ||
| # Overrides the image tag whose default is the chart appVersion. | ||
| tag: "0.5.0" |
Collaborator
There was a problem hiding this comment.
Suggested change
| tag: "0.5.0" | |
| tag: "0.6.0" |
vm-001
reviewed
Apr 30, 2025
- Restructure README with clearer sections and improved formatting - Add comprehensive project overview and prerequisites - Enhance installation instructions with detailed dependency setup - Add configuration examples and development commands - Include Apache 2.0 license file and license section in README - Update chart description and version information
|
PR Review Issues Identified
|
Author
|
@cchenggit Thank you for your suggestion. I will fix these issues later。❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
init helm charts