Skip to content
This repository was archived by the owner on Mar 17, 2021. It is now read-only.

refactor: export as ES2015 Module #10

Merged
joshwiens merged 1 commit into from
Oct 1, 2017
Merged

refactor: export as ES2015 Module #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@
module.exports = function(content) {
this.cacheable && this.cacheable();
this.value = content;
Copy link
Member

@michael-ciniawsky michael-ciniawsky Mar 6, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to the PR but what is this line actually doing 🤔

this.value = content

Copy link

@bebraw bebraw Mar 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. It's some webpack 0.9 fix from 9bbe8b2 . I wonder if that line is even needed now.

Copy link

@mightyiam mightyiam Mar 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated, but from my debugging session, this assignment does not actually occur, as afterwards, this.value remains undefined. Or, actually, not defined at all.

Copy link

@bebraw bebraw Mar 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another note. this.cacheable is set by default now so it would be possible to drop that.

return "module.exports = " + JSON.stringify(content);
return "export default " + JSON.stringify(content);
Copy link

@mightyiam mightyiam Mar 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this why it isn't working for me with import foo from './foo'?

Copy link

@mightyiam mightyiam Mar 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to do

import * as foo from './foo'

which is very wrong... If this will correct behavior, please accept...

Confirmed working with webpack v2.2.1.

}