Conversation
The `escapeHtml` implementation is not adequate for escaping attribute values. Let's just not be using `innerHTML` at all. The issue has been introduced in b32a83e (#119). Seems that anyone who has an app submitted in the store can exploit this vulnerability, by making a release with a malicious app name. I have tested this. Things seem to be working as before.
Member
Author
|
This vulnerability has been privately reported on 15th of February. Merging without review so as to not keep it around any longer. |
Member
Author
|
Confirmed deployment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
escapeHtmlimplementation is not adequatefor escaping attribute values.
Let's just not be using
innerHTMLat all.The issue has been introduced in
b32a83e
(#119).
Seems that anyone who has an app submitted in the store
can exploit this vulnerability,
by making a release with a malicious app name.
I have tested this. Things seem to be working as before.