Skip to content

detach losses when logging #1254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bw4sz merged 1 commit into from
Jan 2, 2026
Merged

detach losses when logging #1254

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/deepforest/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -676,10 +676,12 @@ def training_step(self, batch, batch_idx):

# Log loss
for key, value in loss_dict.items():
self.log(f"train_{key}", value, on_epoch=True, batch_size=len(images))
self.log(
f"train_{key}", value.detach(), on_epoch=True, batch_size=len(images)
)

# Log sum of losses
self.log("train_loss", losses, on_epoch=True, batch_size=len(images))
self.log("train_loss", losses.detach(), on_epoch=True, batch_size=len(images))

return losses

Expand All @@ -699,9 +701,11 @@ def validation_step(self, batch, batch_idx):
# Log losses
try:
for key, value in loss_dict.items():
self.log(f"val_{key}", value, on_epoch=True, batch_size=len(images))
self.log(
f"val_{key}", value.detach(), on_epoch=True, batch_size=len(images)
)

self.log("val_loss", losses, on_epoch=True, batch_size=len(images))
self.log("val_loss", losses.detach(), on_epoch=True, batch_size=len(images))
except MisconfigurationException:
pass

Expand Down