Skip to content

Add regression test for read_file GeoDataFrame return type (#1186) #1339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vickysharma-prog wants to merge 2 commits into
base: main
Choose a base branch
from
+51 −0
Open

Add regression test for read_file GeoDataFrame return type (#1186) #1339

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16ff4f1
Add regression test for read_file GeoDataFrame return type (#1186)
vickysharma-prog Mar 6, 2026
810be7e
Fix assertion order as suggested by reviewer
vickysharma-prog Mar 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 51 additions & 0 deletions tests/test_utilities.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,57 @@ def test_read_file_in_memory_dataframe():
assert result.root_dir == os.path.dirname(get_data("OSBS_029.tif"))



def test_read_file_dataframe_with_geometry_returns_geodataframe():
"""Test that read_file returns GeoDataFrame when DataFrame has geometry column."""
# Test Case 1: DataFrame with WKT string geometry
df_wkt = pd.DataFrame({
'image_path': ['OSBS_029.png', 'OSBS_029.png'],
'xmin': [0, 20],
'ymin': [0, 20],
'xmax': [10, 30],
'ymax': [10, 30],
'label': ['Tree', 'Tree'],
'geometry': [
'POLYGON ((0 0, 0 10, 10 10, 10 0, 0 0))',
'POLYGON ((20 20, 20 30, 30 30, 30 20, 20 20))'
]
})

result_wkt = utilities.read_file(
input=df_wkt,
root_dir=os.path.dirname(get_data('OSBS_029.tif'))
)

assert isinstance(result_wkt, gpd.GeoDataFrame)
assert 'geometry' in result_wkt.columns
Copy link
Copy Markdown
Contributor

@henrykironde henrykironde Mar 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you probably want to move this statement

assert 'geometry' in result_wkt.columns

above

assert isinstance(result_wkt.geometry, gpd.GeoSeries)

assert isinstance(result_wkt.geometry, gpd.GeoSeries)
assert all(result_wkt.geometry.geom_type == 'Polygon')
assert len(result_wkt) == 2

# Test Case 2: DataFrame with shapely geometry objects
df_shapely = pd.DataFrame({
'image_path': ['OSBS_029.png', 'OSBS_029.png'],
'xmin': [0, 20],
'ymin': [0, 20],
'xmax': [10, 30],
'ymax': [10, 30],
'label': ['Tree', 'Tree'],
'geometry': [geometry.box(0, 0, 10, 10), geometry.box(20, 20, 30, 30)]
})

result_shapely = utilities.read_file(
input=df_shapely,
root_dir=os.path.dirname(get_data('OSBS_029.tif'))
)

assert isinstance(result_shapely, gpd.GeoDataFrame)
assert 'geometry' in result_wkt.columns
assert isinstance(result_wkt.geometry, gpd.GeoSeries)
assert all(result_shapely.geometry.geom_type == 'Polygon')
assert len(result_shapely) == 2


def test_convert_point_to_bbox():
sample_geometry = [geometry.Point(10, 20), geometry.Point(20, 40)]
labels = ["Tree", "Tree"]
Expand Down
Loading