Skip to content

fix: uploadedDriversPeriodicCheck should use builder endpoint#2267

Open
rugggger wants to merge 1 commit into02-18-fix_extend_get_version_to_look_for_release_in__shared-weka_folderfrom
02-19-fix_uploadeddriversperiodiccheck_should_use_builder_endpoint
Open

fix: uploadedDriversPeriodicCheck should use builder endpoint#2267
rugggger wants to merge 1 commit into02-18-fix_extend_get_version_to_look_for_release_in__shared-weka_folderfrom
02-19-fix_uploadeddriversperiodiccheck_should_use_builder_endpoint

Conversation

@rugggger
Copy link
Contributor

@rugggger rugggger commented Feb 19, 2026

TL;DR

uploadedDriversPeriodicCheck should use a builder endpoint, just as UploadBuiltDrivers does (otherwise builders with a different weka version from the dist container enter a loop RUNNING->COMPLETED->RUNNING)

Refactored driver download functionality to improve code organization and error handling.

What changed?

  • Extracted driver download logic into a new downloadDriversFromBuilder function to centralize the implementation
  • Renamed "DownloadVersion" exec command to "GetVersion" for better clarity
  • Improved error handling and logging in the driver download process
  • Fixed the legacy driver handling path to properly handle the NoWekaDriversHandling case
  • Removed redundant code in the periodic check function by reusing the download function
  • Enhanced logging to be more consistent and informative

Copy link
Contributor Author

rugggger commented Feb 19, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label main-merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@graphite-app
Copy link

graphite-app bot commented Feb 19, 2026

Graphite Automations

"Add anton/matt/sergey/kristina as reviwers on operator PRs" took an action on this PR • (02/19/26)

3 reviewers were added to this PR based on Anton Bykov's automation.

@rugggger rugggger force-pushed the 02-19-fix_uploadeddriversperiodiccheck_should_use_builder_endpoint branch from 79cf5aa to 414e16b Compare February 19, 2026 10:21
@rugggger rugggger force-pushed the 02-18-fix_extend_get_version_to_look_for_release_in__shared-weka_folder branch from d98e20f to 496036e Compare February 19, 2026 10:21
@rugggger rugggger force-pushed the 02-18-fix_extend_get_version_to_look_for_release_in__shared-weka_folder branch from 496036e to 5561d5c Compare February 19, 2026 15:00
@rugggger rugggger force-pushed the 02-19-fix_uploadeddriversperiodiccheck_should_use_builder_endpoint branch from 414e16b to 3fe058c Compare February 19, 2026 15:00
@graphite-app
Copy link

graphite-app bot commented Feb 19, 2026

Merge activity

  • Feb 19, 3:36 PM UTC: rugggger added this pull request to the Graphite merge queue.
  • Feb 19, 3:37 PM UTC: CI is running for this pull request on a draft pull request (#2271) due to your merge queue CI optimization settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments