Add isExhibition to EventDocument display object
#347
Merged
+1,176
−218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcantin-w
changed the title
isExhibition to EventDocument display object
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an isExhibition boolean field to the EventDocument display object to simplify identifying exhibition-type events. The implementation refactors repeated type === 'exhibitions' checks throughout the transformer by computing isExhibition once and reusing it.
Key changes:
- Added
isExhibition: booleanfield to the EventDocument type definition - Refactored the eventDocument transformer to use a single
isExhibitionvariable instead of repeated type checks - Updated test snapshots to include the new field with correct values (true for exhibitions, false for events)
Reviewed changes
Copilot reviewed 32 out of 32 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pipeline/src/types/transformed/eventDocument.ts | Added isExhibition: boolean field to EventDocument type |
| pipeline/src/transformers/eventDocument.ts | Computed isExhibition variable and used it throughout to replace repeated type checks; added field to display object |
| pipeline/test/transformers/snapshots/eventDocument.test.ts.snap | Updated snapshots with isExhibition field - exhibitions show true, events show false |
| pipeline/test/transformers/snapshots/venues.test.ts.snap | Updated venue opening hours and exceptional closure dates (incidental) |
| pipeline/test/transformers/snapshots/addressables.test.ts.snap | Updated with new linked works data (incidental) |
| pipeline/test/prismic-snapshots/* | Updated Prismic API refs, publication dates, and content (incidental test data refresh) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gestchild
approved these changes
Jan 9, 2026
Contributor
gestchild
left a comment
gestchild
left a comment
There was a problem hiding this comment.
looks good to me and the tests pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
#247
type === 'exhibitions'was repeated a ton so I used the same var for it all too.I think I could run a reindex without the need for a new pipeline since the display object isn't mapped but shout if you think it's needed
How to test
cd pipelineMedicine Man: should have
isExhibition: truein the display object.yarn testTransformer --type=event --id=Weoe4SQAAKJwjcDC --isDetailedHIV and AIDS event: should have
isExhibition: falsein the display object.yarn testTransformer --type=event --isDetailedHow can we measure success?
We can identify if it's an Exhibition and therefore we can make sure the link is correct.
Have we considered potential risks?
N/A ?