[ENGAGE-6323] Fix pin otimization#799
Open
MarcusviniciusLsantos wants to merge 5 commits intomainfrom
Open
Conversation
… more efficiently, reducing unnecessary database queries and improving performance.
- Introduced a new test to verify that filtering occurs before annotating in the optimized pin version, ensuring better performance with large datasets. - Updated existing tests to reflect the expected reduction in query count, emphasizing the importance of efficient database interactions. - Added assertions to confirm correct filtering and ordering of active pinned rooms in the response.
- Cleaned up whitespace in the test code for better readability. - Ensured assertions for query counts are formatted consistently. - Verified that filtering and ordering of active pinned rooms are correctly tested, maintaining performance expectations.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
chats/apps/api/v1/rooms/tests/test_filters_serializers_viewsets.py
Outdated
Show resolved
Hide resolved
- Updated test documentation to specify that pinned rooms are always included in results, regardless of filters, aligning with legacy behavior. - Adjusted assertions to ensure both active and inactive pinned rooms are correctly included in the response, maintaining expected order. - Improved clarity on the sorting of pinned rooms before regular active rooms in the results.
- Cleaned up unnecessary whitespace in the test code to enhance readability. - Ensured that the documentation and assertions remain clear and consistent, maintaining focus on the behavior of pinned rooms in the results.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Improves the rooms list performance and preserves expected pin behavior.
RoomViewset._list_with_optimized_pin_orderto filter first, then:is_pinnedand latestpin_created_onWritten by Cursor Bugbot for commit 34b6d62. This will update automatically on new commits. Configure here.