Skip to content

fix-hotjar #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adenntumba wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix-hotjar #231

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,13 @@ ARG KEEP_DAYS
COPY --chown=nginx:nginx docker/nginx.conf /etc/nginx/nginx.conf
COPY --chown=nginx:nginx docker/headers /usr/share/nginx/html/headers
COPY --chown=nginx:nginx docker/file_handler.sh /
COPY docker/docker-entrypoint.sh /
COPY --from=builder --chown=nginx:nginx /app/dist /app/config.js.tmpl /usr/share/nginx/html/bothub-webapp/
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

It appears that the order of COPY commands has been changed. Previously, docker-entrypoint.sh was copied before the application files. Now, it's being copied after some of the application files. Can you confirm that this change in order doesn't affect the application's startup or behavior? If the entrypoint script relies on any of the files copied in the subsequent steps, this could lead to issues.

COPY --from=old_css --chown=nginx:nginx /usr/share/nginx/html/bothub-webapp/assets/all.tx[t] /usr/share/nginx/html/bothub-webapp/assets/*.css /usr/share/nginx/html/bothub-webapp/assets/
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The original COPY command included /app/config.js.tmpl in the destination path. However, the subsequent COPY command on line 39 only copies /app/dist. Is it intentional that config.js.tmpl is no longer copied to /usr/share/nginx/html/bothub-webapp/config.js.tmpl? If so, please provide a comment explaining why this file is no longer needed in that location, or if it was unintentional, please add it back.


COPY docker/docker-entrypoint.sh /

COPY --from=builder --chown=nginx:nginx /app/dist /usr/share/nginx/html/bothub-webapp/

RUN cd /usr/share/nginx/html/bothub-webapp/ \
&& ln -s /tmp/config.js \
&& /file_handler.sh css
Expand Down
Loading